First working version

Signed-off-by: Ryan Levick <[email protected]>

Author: rylev

crates/key-value-azure/src/lib.rs

@@ -7,15 +7,14 @@ use store::{
 };
 
 /// A key-value store that uses Azure Cosmos as the backend.
-#[derive(Default)]
 pub struct AzureKeyValueStore {
-    _priv: (),
+    app_id: String,
 }
 
 impl AzureKeyValueStore {
     /// Creates a new `AzureKeyValueStore`.
-    pub fn new() -> Self {
-        Self::default()
+    pub fn new(app_id: String) -> Self {
+        Self { app_id }
     }
 }
 
@@ -55,6 +54,7 @@ impl MakeKeyValueStore for AzureKeyValueStore {
             runtime_config.database,
             runtime_config.container,
             auth_options,
+            self.app_id.clone(),
         )
     }
 }

crates/key-value-azure/src/store.rs

@@ -13,6 +13,7 @@ use std::sync::{Arc, Mutex};
 
 pub struct KeyValueAzureCosmos {
     client: CollectionClient,
+    app_id: String,
 }
 
 /// Azure Cosmos Key / Value runtime config literal options for authentication
@@ -71,6 +72,7 @@ impl KeyValueAzureCosmos {
         database: String,
         container: String,
         auth_options: KeyValueAzureCosmosAuthOptions,
+        app_id: String,
     ) -> Result<Self> {
         let token = match auth_options {
             KeyValueAzureCosmosAuthOptions::RuntimeConfigValues(config) => {
@@ -86,15 +88,16 @@ impl KeyValueAzureCosmos {
         let database_client = cosmos_client.database_client(database);
         let client = database_client.collection_client(container);
 
-        Ok(Self { client })
+        Ok(Self { client, app_id })
     }
 }
 
 #[async_trait]
 impl StoreManager for KeyValueAzureCosmos {
-    async fn get(&self, _name: &str) -> Result<Arc<dyn Store>, Error> {
+    async fn get(&self, name: &str) -> Result<Arc<dyn Store>, Error> {
         Ok(Arc::new(AzureCosmosStore {
             client: self.client.clone(),
+            partition_key: format!("{}/{}", self.app_id, name),
         }))
     }
 
@@ -114,13 +117,7 @@ impl StoreManager for KeyValueAzureCosmos {
 #[derive(Clone)]
 struct AzureCosmosStore {
     client: CollectionClient,
-}
-
-struct CompareAndSwap {
-    key: String,
-    client: CollectionClient,
-    bucket_rep: u32,
-    etag: Mutex<Option<String>>,
+    partition_key: String,
 }
 
 #[async_trait]
@@ -134,6 +131,7 @@ impl Store for AzureCosmosStore {
         let pair = Pair {
             id: key.to_string(),
             value: value.to_vec(),
+            partition_key: self.partition_key.clone(),
         };
         self.client
             .create_document(pair)
@@ -145,7 +143,10 @@ impl Store for AzureCosmosStore {
 
     async fn delete(&self, key: &str) -> Result<(), Error> {
         if self.exists(key).await? {
-            let document_client = self.client.document_client(key, &key).map_err(log_error)?;
+            let document_client = self
+                .client
+                .document_client(key, &self.partition_key)
+                .map_err(log_error)?;
             document_client.delete_document().await.map_err(log_error)?;
         }
         Ok(())
@@ -165,7 +166,10 @@ impl Store for AzureCosmosStore {
             .map(|k| format!("'{}'", k))
             .collect::<Vec<String>>()
             .join(", ");
-        let stmt = Query::new(format!("SELECT * FROM c WHERE c.id IN ({})", in_clause));
+        let stmt = Query::new(format!(
+            "SELECT * FROM c WHERE c.id IN ({}) AND partition_key='{}'",
+            in_clause, self.partition_key
+        ));
         let query = self
             .client
             .query_documents(stmt)
@@ -175,9 +179,11 @@ impl Store for AzureCosmosStore {
         let mut stream = query.into_stream::<Pair>();
         while let Some(resp) = stream.next().await {
             let resp = resp.map_err(log_error)?;
-            for (pair, _) in resp.results {
-                res.push((pair.id, Some(pair.value)));
-            }
+            res.extend(
+                resp.results
+                    .into_iter()
+                    .map(|(pair, _)| (pair.id, Some(pair.value))),
+            );
         }
         Ok(res)
     }
@@ -200,7 +206,7 @@ impl Store for AzureCosmosStore {
         let operations = vec![Operation::incr("/value", delta).map_err(log_error)?];
         let _ = self
             .client
-            .document_client(key.clone(), &key.as_str())
+            .document_client(key.clone(), &self.partition_key)
             .map_err(log_error)?
             .patch_document(operations)
             .await
@@ -227,10 +233,19 @@ impl Store for AzureCosmosStore {
             client: self.client.clone(),
             etag: Mutex::new(None),
             bucket_rep,
+            partition_key: self.partition_key.clone(),
         }))
     }
 }
 
+struct CompareAndSwap {
+    key: String,
+    client: CollectionClient,
+    bucket_rep: u32,
+    etag: Mutex<Option<String>>,
+    partition_key: String,
+}
+
 #[async_trait]
 impl Cas for CompareAndSwap {
     /// `current` will fetch the current value for the key and store the etag for the record. The
@@ -239,8 +254,8 @@ impl Cas for CompareAndSwap {
         let mut stream = self
             .client
             .query_documents(Query::new(format!(
-                "SELECT * FROM c WHERE c.id='{}'",
-                self.key
+                "SELECT * FROM c WHERE c.id='{}' and c.partition_key='{}'",
+                self.key, self.partition_key
             )))
             .query_cross_partition(true)
             .max_item_count(1)
@@ -272,10 +287,11 @@ impl Cas for CompareAndSwap {
     /// `swap` updates the value for the key using the etag saved in the `current` function for
     /// optimistic concurrency.
     async fn swap(&self, value: Vec<u8>) -> Result<(), SwapError> {
-        let pk = PartitionKey::from(&self.key);
+        let pk = PartitionKey::from(&self.partition_key);
         let pair = Pair {
             id: self.key.clone(),
             value,
+            partition_key: self.partition_key.clone(),
         };
 
         let doc_client = self
@@ -318,23 +334,23 @@ impl AzureCosmosStore {
     async fn get_pair(&self, key: &str) -> Result<Option<Pair>, Error> {
         let query = self
             .client
-            .query_documents(Query::new(format!("SELECT * FROM c WHERE c.id='{}'", key)))
+            .query_documents(Query::new(format!(
+                "SELECT * FROM c WHERE c.id='{}' AND c.partition_key='{}'",
+                key, self.partition_key
+            )))
             .query_cross_partition(true)
             .max_item_count(1);
 
         // There can be no duplicated keys, so we create the stream and only take the first result.
         let mut stream = query.into_stream::<Pair>();
-        let res = stream.next().await;
-        match res {
-            Some(r) => {
-                let r = r.map_err(log_error)?;
-                match r.results.first().cloned() {
-                    Some((p, _)) => Ok(Some(p)),
-                    None => Ok(None),
-                }
-            }
-            None => Ok(None),
-        }
+        let Some(res) = stream.next().await else {
+            return Ok(None);
+        };
+        Ok(res
+            .map_err(log_error)?
+            .results
+            .first()
+            .map(|(p, _)| p.clone()))
     }
 
     async fn get_keys(&self) -> Result<Vec<String>, Error> {
@@ -347,9 +363,7 @@ impl AzureCosmosStore {
         let mut stream = query.into_stream::<Pair>();
         while let Some(resp) = stream.next().await {
             let resp = resp.map_err(log_error)?;
-            for (pair, _) in resp.results {
-                res.push(pair.id);
-            }
+            res.extend(resp.results.into_iter().map(|(pair, _)| pair.id));
         }
 
         Ok(res)
@@ -358,15 +372,15 @@ impl AzureCosmosStore {
 
 #[derive(Serialize, Deserialize, Clone, Debug)]
 pub struct Pair {
-    // In Azure CosmosDB, the default partition key is "/id", and this implementation assumes that partition ID is not changed.
     pub id: String,
     pub value: Vec<u8>,
+    pub partition_key: String,
 }
 
 impl CosmosEntity for Pair {
     type Entity = String;
 
     fn partition_key(&self) -> Self::Entity {
-        self.id.clone()
+        self.partition_key.clone()
     }
 }

crates/runtime-config/src/lib.rs

@@ -403,7 +403,9 @@ pub fn key_value_config_resolver(
         .register_store_type(spin_key_value_redis::RedisKeyValueStore::new())
         .unwrap();
     key_value
-        .register_store_type(spin_key_value_azure::AzureKeyValueStore::new())
+        .register_store_type(spin_key_value_azure::AzureKeyValueStore::new(
+            "MY_APP".to_owned(),
+        ))
         .unwrap();
     key_value
         .register_store_type(spin_key_value_aws::AwsDynamoKeyValueStore::new())