Skip to content

Commit d17ecb7

Browse files
Requested changes addressed
Signed-off-by: Archisman Mridha <[email protected]>
1 parent 4a47530 commit d17ecb7

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

crates/loader/src/local.rs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ impl LocalLoader {
9494
})
9595
.collect::<Result<Vec<_>>>()?;
9696

97-
warn_if_component_load_slothful();
97+
let sloth_guard = warn_if_component_load_slothful();
9898

9999
// Load all components concurrently
100100
let components = try_join_all(components.into_iter().map(|(id, c)| async move {
@@ -104,6 +104,8 @@ impl LocalLoader {
104104
}))
105105
.await?;
106106

107+
drop(sloth_guard);
108+
107109
Ok(LockedApp {
108110
spin_lock_version: Default::default(),
109111
metadata,
@@ -522,6 +524,6 @@ fn file_url(path: impl AsRef<Path>) -> Result<String> {
522524
const SLOTH_WARNING_DELAY_MILLIS: u64 = 1250;
523525

524526
fn warn_if_component_load_slothful() -> sloth::SlothGuard {
525-
let message = "WASM components loading is taking a few seconds...";
527+
let message = "Loading Wasm components is taking a few seconds...";
526528
sloth::warn_if_slothful(SLOTH_WARNING_DELAY_MILLIS, format!("{message}\n"))
527529
}

crates/oci/src/loader.rs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,6 @@ impl OciLoader {
2424

2525
/// Pulls and loads an OCI Artifact and returns a LockedApp with the given OCI client and reference
2626
pub async fn load_app(&self, client: &mut Client, reference: &str) -> Result<LockedApp> {
27-
// Fix: https://github.com/fermyon/spin/issues/2109.
28-
println!("pulling spin application from registry reference {reference:?}...");
29-
3027
// Fetch app
3128
client.pull(reference).await.with_context(|| {
3229
format!("cannot pull Spin application from registry reference {reference:?}")

0 commit comments

Comments
 (0)