Attribution is key

Signed-off-by: Caleb Schoepp <[email protected]>

Author: calebschoepp

crates/factor-observe/src/lib.rs

@@ -89,7 +89,8 @@ pub struct ObserveContext {
 
 impl ObserveContext {
     /// TODO comment
-    pub fn oh_dear_i_better_get_renamed(&self) {
+    /// Make sure to mention this should only be called from an instrumented function in a factor.
+    pub fn reparent_tracing_span_this_was_lanns_idea(&self) {
         // TODO: Move this duplicate logic into its own impl
         let state = self.state.read().unwrap();
         if state.active_spans.is_empty() {

crates/factor-outbound-http/src/spin.rs

@@ -13,7 +13,8 @@ impl spin_http::Host for crate::InstanceState {
         fields(otel.kind = "client", url.full = Empty, http.request.method = Empty,
         http.response.status_code = Empty, otel.name = Empty, server.address = Empty, server.port = Empty))]
     async fn send_request(&mut self, req: Request) -> Result<Response, HttpError> {
-        self.observe_context.oh_dear_i_better_get_renamed();
+        self.observe_context
+            .reparent_tracing_span_this_was_lanns_idea();
 
         let span = Span::current();
         record_request_fields(&span, &req);

crates/factor-outbound-http/src/wasi.rs

@@ -86,7 +86,9 @@ impl<'a> WasiHttpView for WasiHttpImplInner<'a> {
         mut request: Request<wasmtime_wasi_http::body::HyperOutgoingBody>,
         mut config: wasmtime_wasi_http::types::OutgoingRequestConfig,
     ) -> wasmtime_wasi_http::HttpResult<wasmtime_wasi_http::types::HostFutureIncomingResponse> {
-        self.state.observe_context.oh_dear_i_better_get_renamed();
+        self.state
+            .observe_context
+            .reparent_tracing_span_this_was_lanns_idea();
 
         // wasmtime-wasi-http fills in scheme and authority for relative URLs
         // (e.g. https://:443/<path>), which makes them hard to reason about.