Merge pull request #3289 from itowlson/who-will-rid-me-of-this-turbulent-flake

itowlson · web-flow · commit e4a160066d43 · 2025-10-06T13:44:04.000+13:00
Ignore the flaky private IPs test on all platforms
diff --git a/crates/factor-outbound-http/tests/factor_test.rs b/crates/factor-outbound-http/tests/factor_test.rs
@@ -67,7 +67,7 @@ async fn disallowed_host_fails() -> anyhow::Result<()> {
     Ok(())
 }
 
-#[cfg_attr(target_os = "macos", ignore)]
+#[ignore = "flaky"]
 #[tokio::test(flavor = "multi_thread")]
 async fn disallowed_private_ips_fails() -> anyhow::Result<()> {
     async fn run_test(allow_private_ips: bool) -> anyhow::Result<()> {

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ async fn disallowed_host_fails() -> anyhow::Result<()> {`
`67`	`67`	`Ok(())`
`68`	`68`	`}`
`69`	`69`
`70`		`-#[cfg_attr(target_os = "macos", ignore)]`
	`70`	`+#[ignore = "flaky"]`
`71`	`71`	`#[tokio::test(flavor = "multi_thread")]`
`72`	`72`	`async fn disallowed_private_ips_fails() -> anyhow::Result<()> {`
`73`	`73`	`async fn run_test(allow_private_ips: bool) -> anyhow::Result<()> {`