add todo comments and change more bails to unreachables

dicej · dicej · commit e75fe7f17b6d · 2025-10-02T15:54:46.000-06:00
Signed-off-by: Joel Dice &lt;joel.dice@fermyon.com&gt;
diff --git a/crates/factor-outbound-http/src/wasi.rs b/crates/factor-outbound-http/src/wasi.rs
@@ -728,6 +728,8 @@ fn dns_error(rcode: String, info_code: u16) -> ErrorCode {
     })
 }
 
+// TODO: Remove this (and uses of it) once
+// https://github.com/spinframework/spin/issues/3274 has been addressed.
 pub fn p2_to_p3_error_code(code: p2_types::ErrorCode) -> p3_types::ErrorCode {
     match code {
         p2_types::ErrorCode::DnsTimeout => p3_types::ErrorCode::DnsTimeout,
@@ -828,6 +830,8 @@ pub fn p2_to_p3_error_code(code: p2_types::ErrorCode) -> p3_types::ErrorCode {
     }
 }
 
+// TODO: Remove this (and uses of it) once
+// https://github.com/spinframework/spin/issues/3274 has been addressed.
 pub fn p3_to_p2_error_code(code: p3_types::ErrorCode) -> p2_types::ErrorCode {
     match code {
         p3_types::ErrorCode::DnsTimeout => p2_types::ErrorCode::DnsTimeout,
diff --git a/crates/trigger-http/src/spin.rs b/crates/trigger-http/src/spin.rs
@@ -30,7 +30,7 @@ impl HttpExecutor for SpinHttpExecutor {
     ) -> Result<Response<Body>> {
         let spin_http::routes::TriggerLookupKey::Component(component_id) = route_match.lookup_key()
         else {
-            anyhow::bail!("INCONCEIVABLE");
+            unreachable!()
         };
 
         tracing::trace!("Executing request using the Spin executor for component {component_id}");
diff --git a/crates/trigger-http/src/wagi.rs b/crates/trigger-http/src/wagi.rs
@@ -29,7 +29,7 @@ impl HttpExecutor for WagiHttpExecutor<'_> {
     ) -> Result<Response<Body>> {
         let spin_http::routes::TriggerLookupKey::Component(component) = route_match.lookup_key()
         else {
-            anyhow::bail!("INCONCEIVABLE");
+            unreachable!()
         };
 
         tracing::trace!(

Original file line number	Diff line number	Diff line change
`@@ -728,6 +728,8 @@ fn dns_error(rcode: String, info_code: u16) -> ErrorCode {`
`728`	`728`	`})`
`729`	`729`	`}`
`730`	`730`
	`731`	`+// TODO: Remove this (and uses of it) once`
	`732`	`+// https://github.com/spinframework/spin/issues/3274 has been addressed.`
`731`	`733`	`pub fn p2_to_p3_error_code(code: p2_types::ErrorCode) -> p3_types::ErrorCode {`
`732`	`734`	`match code {`
`733`	`735`	`p2_types::ErrorCode::DnsTimeout => p3_types::ErrorCode::DnsTimeout,`
`@@ -828,6 +830,8 @@ pub fn p2_to_p3_error_code(code: p2_types::ErrorCode) -> p3_types::ErrorCode {`
`828`	`830`	`}`
`829`	`831`	`}`
`830`	`832`
	`833`	`+// TODO: Remove this (and uses of it) once`
	`834`	`+// https://github.com/spinframework/spin/issues/3274 has been addressed.`
`831`	`835`	`pub fn p3_to_p2_error_code(code: p3_types::ErrorCode) -> p2_types::ErrorCode {`
`832`	`836`	`match code {`
`833`	`837`	`p3_types::ErrorCode::DnsTimeout => p2_types::ErrorCode::DnsTimeout,`