Enable skipping target validation for offline or to bypass delays

Signed-off-by: itowlson <[email protected]>

Author: itowlson

crates/build/src/lib.rs

@@ -17,7 +17,7 @@ use subprocess::{Exec, Redirection};
 use crate::manifest::component_build_configs;
 
 /// If present, run the build command of each component.
-pub async fn build(manifest_file: &Path, component_ids: &[String]) -> Result<()> {
+pub async fn build(manifest_file: &Path, component_ids: &[String], skip_target_checks: bool) -> Result<()> {
     let (components, deployment_targets, manifest) = component_build_configs(manifest_file)
         .await
         .with_context(|| {
@@ -37,7 +37,8 @@ pub async fn build(manifest_file: &Path, component_ids: &[String]) -> Result<()>
     build_result?;
 
     if let Ok(manifest) = &manifest {
-        if !deployment_targets.is_empty() {
+        let should_check_targets = !skip_target_checks && !deployment_targets.is_empty();
+        if should_check_targets {
             let resolution_context =
                 spin_environments::ResolutionContext::new(manifest_file.parent().unwrap()).await?;
             spin_environments::validate_application_against_environment_ids(
@@ -163,6 +164,6 @@ mod tests {
     #[tokio::test]
     async fn can_load_even_if_trigger_invalid() {
         let bad_trigger_file = test_data_root().join("bad_trigger.toml");
-        build(&bad_trigger_file, &[]).await.unwrap();
+        build(&bad_trigger_file, &[], true).await.unwrap();
     }
 }

src/commands/build.rs

@@ -29,6 +29,12 @@ pub struct BuildCommand {
     #[clap(short = 'c', long, multiple = true)]
     pub component_id: Vec<String>,
 
+    /// By default, if the application manifest specifies one or more deployment targets, Spin
+    /// checks that all components are compatible with those deployment targets. Specify
+    /// this option to bypass those target checks.
+    #[clap(long = "skip-target-checks", alias = "skip-target-check", takes_value = false)]
+    skip_target_checks: bool,
+
     /// Run the application after building.
     #[clap(name = BUILD_UP_OPT, short = 'u', long = "up")]
     pub up: bool,
@@ -43,7 +49,7 @@ impl BuildCommand {
             spin_common::paths::find_manifest_file_path(self.app_source.as_ref())?;
         notify_if_nondefault_rel(&manifest_file, distance);
 
-        spin_build::build(&manifest_file, &self.component_id).await?;
+        spin_build::build(&manifest_file, &self.component_id, self.skip_target_checks).await?;
 
         if self.up {
             let mut cmd = UpCommand::parse_from(

src/commands/registry.rs

@@ -49,7 +49,7 @@ pub struct Push {
     )]
     pub insecure: bool,
 
-    /// Specifies to perform `spin build` before pushing the application.
+    /// Specifies to perform `spin build` (with the default options) before pushing the application.
     #[clap(long, takes_value = false, env = ALWAYS_BUILD_ENV)]
     pub build: bool,
 
@@ -75,7 +75,7 @@ impl Push {
         notify_if_nondefault_rel(&app_file, distance);
 
         if self.build {
-            spin_build::build(&app_file, &[]).await?;
+            spin_build::build(&app_file, &[], false).await?;
         }
 
         let annotations = if self.annotations.is_empty() {

src/commands/up.rs

@@ -108,7 +108,7 @@ pub struct UpCommand {
     #[clap(long, takes_value = false)]
     pub direct_mounts: bool,
 
-    /// For local apps, specifies to perform `spin build` before running the application.
+    /// For local apps, specifies to perform `spin build` (with the default options) before running the application.
     ///
     /// This is ignored on remote applications, as they are already built.
     #[clap(long, takes_value = false, env = ALWAYS_BUILD_ENV)]

src/commands/up/app_source.rs

@@ -58,7 +58,7 @@ impl AppSource {
 
     pub async fn build(&self) -> anyhow::Result<()> {
         match self {
-            Self::File(path) => spin_build::build(path, &[]).await,
+            Self::File(path) => spin_build::build(path, &[], false).await,
             _ => Ok(()),
         }
     }