Skip to content

Commit eeb1905

Browse files
committed
warn of error
Signed-off-by: Aminu 'Seun Joshua <[email protected]>
1 parent 69fe11e commit eeb1905

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

crates/trigger/src/cli/stdio.rs

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,15 +117,21 @@ impl<F: RuntimeFactors, U> ExecutorHooks<F, U> for StdioLoggingExecutorHooks {
117117
&sanitized_component_id,
118118
STDOUT_LOG_FILE_SUFFIX,
119119
) {
120-
let _ = std::fs::File::create(stdout_log_path);
120+
if let Err(err) = std::fs::File::create(stdout_log_path) {
121+
//TODO: figure out if we want to return error here
122+
tracing::warn!("Failed to refresh stdout log file: {}", err);
123+
}
121124
}
122125

123126
if let Some(stderr_log_path) = santized_log_path(
124127
self.log_dir.as_deref(),
125128
&sanitized_component_id,
126129
STDERR_LOG_FILE_SUFFIX,
127130
) {
128-
let _ = std::fs::File::create(stderr_log_path);
131+
if let Err(err) = std::fs::File::create(stderr_log_path) {
132+
//TODO: figure out if we want to return error here
133+
tracing::warn!("Failed to refresh stderr log file: {}", err);
134+
}
129135
}
130136
}
131137
}

0 commit comments

Comments
 (0)