Skip to content

Conversation

@Mossaka
Copy link
Member

@Mossaka Mossaka commented Oct 1, 2024

remove unused dependencies found by running cargo machete

remove unused dependencies found by running `cargo machete`

Signed-off-by: Jiaxiao Zhou (Mossaka) <[email protected]>
Signed-off-by: Jiaxiao Zhou (Mossaka) <[email protected]>
@fibonacci1729
Copy link
Collaborator

Looks good! Ran cargo machete myself and noticed a bunch of unused dependencies exist in the tests/examples; would you be up for deleting those in this PR?

@Mossaka
Copy link
Member Author

Mossaka commented Oct 3, 2024

yeah sure I will remove these ones from the example/tests

@Mossaka
Copy link
Member Author

Mossaka commented Oct 3, 2024

I've removed all deps, except wit-bindgen in tests, which is actually used.

@Mossaka Mossaka closed this Oct 4, 2024
@Mossaka Mossaka reopened this Oct 4, 2024
@fibonacci1729 fibonacci1729 disabled auto-merge October 4, 2024 00:35
@fibonacci1729 fibonacci1729 merged commit cd76971 into spinframework:main Oct 7, 2024
32 of 33 checks passed
@Mossaka Mossaka deleted the remove-deps branch October 7, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants