Ignore MQTT test flake #2901
Merged
Ignore MQTT test flake #2901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itowlson
force-pushed
the
ignore-mqtt-flake
branch
from
c1bd33c to
e7fa128
Compare
Collaborator
Author
|
Didn't work! I'll keep investigating |
vdice
reviewed
Nov 4, 2024
Signed-off-by: itowlson <[email protected]>
itowlson
force-pushed
the
ignore-mqtt-flake
branch
from
e7fa128 to
7dd1a68
Compare
Collaborator
Author
|
BECAUSE I MADE A STUPID TYPO THAT IS WHY |
Collaborator
Author
|
Of course now it hits two different flakes...! |
Contributor
😂 😭 |
vdice
approved these changes
Nov 4, 2024
Collaborator
|
Do we know why this is flaky? Are we tracking the flakiness anywhere? |
Collaborator
Author
|
We don't know, and yes, I should raise an issue. We can look into the Postgres tests while we're at it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is right. Although if it's wrong then I bet it's the one time the flake doesn't whomp us.