Fix spin-factor-outbound-http tests #3190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fibonacci1729
approved these changes
Jul 8, 2025
These two tests worked on the assumption that connections to the IPv6 "Discard Prefix" would always result in "connection refused". This is apparently not the case, so additionally set a very short connect timeout and treat timeout as 'success' as well. Signed-off-by: Lann Martin <[email protected]>
lann
force-pushed
the
fix-outbound-http-tests
branch
from
3ddb954 to
a6d05f7
Compare
fibonacci1729
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two tests worked on the assumption that connections to the IPv6 "Discard Prefix" would always result in "connection refused". This is apparently not the case, so switch to using a very short connect timeout as a proxy for successfully passing pre-connect security checks.
Fixes #2338