From 559953402c35673f849bbe052dc22907cb752d2b Mon Sep 17 00:00:00 2001
From: Aminu Oluwaseun Joshua <seun.aminujoshua@gmail.com>
Date: Fri, 29 Aug 2025 13:02:33 +0100
Subject: [PATCH] remove restriction for LLM model names

Some LLM model names contain colon or numbers after a hyphen which was previously rejected
by the manifest parser. This change allows these special cases.

Signed-off-by: Aminu Oluwaseun Joshua <seun.aminujoshua@gmail.com>
---
 crates/manifest/src/compat.rs    | 7 +------
 crates/manifest/src/schema/v2.rs | 2 +-
 2 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/crates/manifest/src/compat.rs b/crates/manifest/src/compat.rs
index 4cca17cd3a..eb88524167 100644
--- a/crates/manifest/src/compat.rs
+++ b/crates/manifest/src/compat.rs
@@ -42,11 +42,6 @@ pub fn v1_to_v2_app(manifest: v1::AppManifestV1) -> Result<v2::AppManifest, Erro
             .map(|(key, var)| Ok((id_from_string(key)?, var)))
             .collect::<Result<_, Error>>()?;
 
-        let ai_models = component
-            .ai_models
-            .into_iter()
-            .map(id_from_string)
-            .collect::<Result<_, Error>>()?;
         let allowed_http = convert_allowed_http_to_allowed_hosts(
             &component.allowed_http_hosts,
             component.allowed_outbound_hosts.is_none(),
@@ -71,7 +66,7 @@ pub fn v1_to_v2_app(manifest: v1::AppManifestV1) -> Result<v2::AppManifest, Erro
                 exclude_files: component.exclude_files,
                 key_value_stores: component.key_value_stores,
                 sqlite_databases: component.sqlite_databases,
-                ai_models,
+                ai_models: component.ai_models,
                 build: component.build,
                 tool: Default::default(),
                 allowed_outbound_hosts,
diff --git a/crates/manifest/src/schema/v2.rs b/crates/manifest/src/schema/v2.rs
index b656169387..238139ced0 100644
--- a/crates/manifest/src/schema/v2.rs
+++ b/crates/manifest/src/schema/v2.rs
@@ -373,7 +373,7 @@ pub struct Component {
     /// Learn more: https://spinframework.dev/serverless-ai-api-guide#using-serverless-ai-from-applications
     #[serde(default, skip_serializing_if = "Vec::is_empty")]
     #[schemars(with = "Vec<json_schema::AIModel>")]
-    pub ai_models: Vec<KebabId>,
+    pub ai_models: Vec<String>,
     /// The component build configuration.
     ///
     /// Learn more: https://spinframework.dev/build