-
Notifications
You must be signed in to change notification settings - Fork 289
Outbound http permits metrics #3313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I'll take it over nothing! It would be good to have |
|
@lann @calebschoepp the only thing I'm unsure about is whether |
It should work. It is using |
Signed-off-by: Ryan Levick <[email protected]>
Signed-off-by: Ryan Levick <[email protected]>
Signed-off-by: Ryan Levick <[email protected]>
776d3d7 to
85d66c1
Compare
|
@calebschoepp can I get another review? I didn't end up using the gauge macro in this PR because I don't have time to thread that through, but I think we don't need to delay merging this any more. |
Signed-off-by: Ryan Levick <[email protected]>
fe1da82 to
8cc9dab
Compare
|
@lann ping - looks like I need you to give this a 👍 |
Partially fixes #3307
I didn't implement a gauge of
available_permitsfor two reasons:spin_telemetryCurious what folks think about this.