fix(pipelineStage): Rendering with a warning with the pipelineParameters are defined as a SpeL expression (#10168)

Author: christosarvanitis

packages/core/src/pipeline/config/stages/pipeline/pipelineStage.html

@@ -104,6 +104,17 @@ <h4 class="text-left">Pipeline Parameters</h4>
         <button class="self-right passive" ng-click="pipelineStageCtrl.removeInvalidParameters()">Remove all</button>
       </div>
     </div>
+    <div ng-if="hasSpeLDefinedParameterBlock()" class="horizontal center sp-margin-l-top" style="width: 100%">
+      <div class="warning-text alert-info vertical">
+        <p>
+          <i class="fa fa-exclamation-triangle"></i>
+          The pipelineParameters is defined as a SpeL expression and will be fully evaluated on Runtime.
+        </p>
+        <p>
+          <code ng-bind-html="stage.pipelineParameters"></code>
+        </p>
+      </div>
+    </div>
   </div>
   <stage-config-field label="Skip downstream output" help-key="pipeline.skipDownstreamOutput">
     <input type="checkbox" class="input-sm" name="skipDownstreamOutput" ng-model="stage.skipDownstreamOutput" />

packages/core/src/pipeline/config/stages/pipeline/pipelineStage.js

@@ -70,7 +70,12 @@ module(CORE_PIPELINE_CONFIG_STAGES_PIPELINE_PIPELINESTAGE, [])
         $scope.applications = _.map(applications, 'name').sort();
         initializeMasters();
       });
-
+      const isExpression =
+        $scope.stage.pipelineParameters !== undefined &&
+        $scope.stage.pipelineParameters !== null &&
+        typeof $scope.stage.pipelineParameters === 'string'
+          ? $scope.stage.pipelineParameters.startsWith('${') && $scope.stage.pipelineParameters.endsWith('}')
+          : false;
       function initializeMasters() {
         if ($scope.stage.application && !$scope.stage.application.includes('${')) {
           PipelineConfigService.getPipelinesForApplication($scope.stage.application).then(function (pipelines) {
@@ -130,12 +135,14 @@ module(CORE_PIPELINE_CONFIG_STAGES_PIPELINE_PIPELINESTAGE, [])
               (value, name) => !acceptedPipelineParams.includes(name),
             );
           }
-
-          $scope.hasInvalidParameters = () => Object.keys($scope.invalidParameters || {}).length;
+          $scope.hasSpeLDefinedParameterBlock = () => isExpression;
+          $scope.hasInvalidParameters = () => Object.keys(($scope.invalidParameters && !isExpression) || {}).length;
           $scope.useDefaultParameters = {};
           _.each($scope.pipelineParameters, function (property) {
-            if (!(property.name in $scope.stage.pipelineParameters) && property.default !== null) {
-              $scope.useDefaultParameters[property.name] = true;
+            if (!isExpression) {
+              if (!(property.name in $scope.stage.pipelineParameters) && property.default !== null) {
+                $scope.useDefaultParameters[property.name] = true;
+              }
             }
           });
         } else {