Skip to content

Commit d8ab240

Browse files
authored
fix(release): Fix changelog generation (#105)
Every kleat release was generating a full changelog of all commits ever made rather than only those since the last release. The reason for this is that we were not fetching tags when cloning the repository, so when go-releaser used 'git describe' to find the last tag, it was not finding one and thus generating a changelog of all commits ever made. This could be fixed by adding a --tags to the unshallow command, but it looks like the github action will fetch tags if you pass depth=0 to it (which means fetch all commits) so let's do that instead. It looks like in the two weeks since we added this config, go-releaser has updated their docs to now suggest adding depth=0 to the checkout command (whereas they previously had the unshallow command that was broken).
1 parent 2892472 commit d8ab240

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

.github/workflows/release.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,10 @@ jobs:
1010
if: startsWith(github.repository, 'spinnaker/')
1111
runs-on: ubuntu-latest
1212
steps:
13-
- uses: actions/checkout@v2
14-
- name: Unshallow
15-
run: git fetch --prune --unshallow
13+
- name: Checkout
14+
uses: actions/checkout@v2
15+
with:
16+
fetch-depth: 0
1617
- name: Install Go
1718
uses: actions/setup-go@v1
1819
with:

0 commit comments

Comments
 (0)