Merge pull request #1208: Apply risky Code Style rules

Author: spiralbot

src/helpers.php

@@ -9,7 +9,7 @@
 use Spiral\Core\ContainerScope;
 use Spiral\Core\Exception\ScopeException;
 
-if (!function_exists('spiral')) {
+if (!\function_exists('spiral')) {
     /**
      * Resolve given alias in current IoC scope.
      *
@@ -34,7 +34,7 @@ function spiral(string $alias): mixed
     }
 }
 
-if (!function_exists('directory')) {
+if (!\function_exists('directory')) {
     /**
      * Get directory alias value. Uses application core from the current global scope.
      *
@@ -49,7 +49,7 @@ function directory(string $alias): string
     }
 }
 
-if (!function_exists('env')) {
+if (!\function_exists('env')) {
     /**
      * Gets the value of an environment variable. Uses application core from the current global scope.
      *

tests/DirectoriesTest.php

@@ -93,7 +93,7 @@ public function testGetException(): void
 
     private function assertDir($path, $value): void
     {
-        $path = str_replace(['\\', '//'], '/', $path);
-        self::assertSame(rtrim($path, '/') . '/', $value);
+        $path = \str_replace(['\\', '//'], '/', $path);
+        self::assertSame(\rtrim($path, '/') . '/', $value);
     }
 }

tests/FinalizerTest.php

@@ -14,7 +14,7 @@ public function testFinalize(): void
         $f = new Finalizer();
 
         $value = 1;
-        $f->addFinalizer(function () use (&$value): void {
+        $f->addFinalizer(static function () use (&$value): void {
             $value = 2;
         });
 

tests/Fixtures/BrokenCore.php

@@ -27,7 +27,7 @@ protected function mapDirectories(array $directories): array
             $directories['app'] = $directories['root'] . '/app/';
         }
 
-        return array_merge([
+        return \array_merge([
             // public root
             'public' => $directories['root'] . '/public/',
 

tests/Fixtures/ConfigBootloader.php

@@ -18,22 +18,22 @@ class ConfigBootloader extends Bootloader
 
     public function init(Container $container, AbstractKernel $kernel): void
     {
-        $kernel->booting(static function (AbstractKernel $kernel) use ($container) {
+        $kernel->booting(static function (AbstractKernel $kernel) use ($container): void {
             $container->bind('hij', 'foo');
 
-            $kernel->booting(static function () use ($container) {
+            $kernel->booting(static function () use ($container): void {
                 $container->bind('ijk', 'foo');
             });
         });
 
-        $kernel->booted(function (AbstractKernel $kernel) use ($container) {
+        $kernel->booted(static function (AbstractKernel $kernel) use ($container): void {
             $container->bind('jkl', 'foo');
 
-            $kernel->booting(function () use ($container) {
+            $kernel->booting(static function () use ($container): void {
                 $container->bind('klm', 'foo');
             });
 
-            $kernel->booted(function () use ($container) {
+            $kernel->booted(static function () use ($container): void {
                 $container->bind('lmn', 'foo');
             });
         });
@@ -44,11 +44,11 @@ public function init(Container $container, AbstractKernel $kernel): void
     public function boot(ConfigurationBootloader $configuration, AbstractKernel $kernel, Container $container): void
     {
         // won't be executed
-        $kernel->booting(function (AbstractKernel $kernel) use ($container) {
+        $kernel->booting(static function (AbstractKernel $kernel) use ($container): void {
             $container->bind('ghi', 'foo');
         });
 
-        $kernel->booted(function (AbstractKernel $kernel) use ($container) {
+        $kernel->booted(static function (AbstractKernel $kernel) use ($container): void {
             $container->bind('mno', 'foo');
         });
 

tests/Fixtures/TestCore.php

@@ -46,7 +46,7 @@ protected function mapDirectories(array $directories): array
             $directories['app'] = $directories['root'] . '/app/';
         }
 
-        return array_merge([
+        return \array_merge([
             // public root
             'public'    => $directories['root'] . '/public/',
 

tests/FunctionsTest.php

@@ -24,7 +24,7 @@ public function testSpiral(): void
         /** @var ContainerInterface $c */
         $c = $core->getContainer();
 
-        ContainerScope::runScope($c, function (): void {
+        ContainerScope::runScope($c, static function (): void {
             self::assertSame(['key' => 'value'], spiral(TestConfig::class)->toArray());
         });
     }
@@ -41,7 +41,7 @@ public function testEnv(): void
         /** @var ContainerInterface $c */
         $c = $core->getContainer();
 
-        ContainerScope::runScope($c, function (): void {
+        ContainerScope::runScope($c, static function (): void {
             self::assertTrue(env('key'));
         });
     }
@@ -80,7 +80,7 @@ public function testSpiralException2(): void
         /** @var ContainerInterface $c */
         $c = $core->getContainer();
 
-        ContainerScope::runScope($c, function (): void {
+        ContainerScope::runScope($c, static function (): void {
             spiral(Invalid::class);
         });
     }
@@ -101,7 +101,7 @@ public function testDirectoryException(): void
 
     private function assertDir($path, $value): void
     {
-        $path = str_replace(['\\', '//'], '/', $path);
-        self::assertSame(rtrim($path, '/') . '/', $value);
+        $path = \str_replace(['\\', '//'], '/', $path);
+        self::assertSame(\rtrim($path, '/') . '/', $value);
     }
 }

tests/MemoryTest.php

@@ -24,7 +24,7 @@ public function testMemory(): void
         self::assertFileExists(__DIR__ . '/cache/test.php');
         self::assertSame('data', $memory->loadData('test'));
 
-        unlink(__DIR__ . '/cache/test.php');
+        \unlink(__DIR__ . '/cache/test.php');
         self::assertNull($memory->loadData('test'));
     }
 
@@ -38,10 +38,10 @@ public function testBroken(): void
         /** @var MemoryInterface $memory */
         $memory = $core->getContainer()->get(MemoryInterface::class);
 
-        file_put_contents(__DIR__ . '/cache/test.php', '<?php broken');
+        \file_put_contents(__DIR__ . '/cache/test.php', '<?php broken');
         self::assertNull($memory->loadData('test'));
 
-        unlink(__DIR__ . '/cache/test.php');
+        \unlink(__DIR__ . '/cache/test.php');
         self::assertNull($memory->loadData('test'));
     }
 }