feat: replace GeneratorConfig with modular PropertyDataExtractor system

- Introduce PropertyDataExtractorInterface for validation constraint extraction
- Add CompositePropertyDataExtractor with fluent API for extractor composition
- Refactor AttributeConstraintExtractor and ValidationConstraintExtractor to implement new interface

Author: butschster

src/Generator.php

@@ -14,23 +14,20 @@
 use Spiral\JsonSchemaGenerator\Schema\Definition;
 use Spiral\JsonSchemaGenerator\Schema\Property;
 use Spiral\JsonSchemaGenerator\Schema\PropertyType;
-use Spiral\JsonSchemaGenerator\Validation\ValidationConstraintExtractor;
-use Spiral\JsonSchemaGenerator\Validation\AttributeConstraintExtractor;
+use Spiral\JsonSchemaGenerator\Validation\CompositePropertyDataExtractor;
+use Spiral\JsonSchemaGenerator\Validation\PropertyDataExtractorInterface;
 
 final class Generator implements GeneratorInterface
 {
     protected array $cache = [];
-    private readonly ValidationConstraintExtractor $validationExtractor;
-    private readonly AttributeConstraintExtractor $attributeExtractor;
+    protected readonly PropertyDataExtractorInterface $propertyDataExtractor;
 
     public function __construct(
         protected readonly ParserInterface $parser = new Parser(),
-        ?ValidationConstraintExtractor $validationExtractor = null,
-        protected readonly GeneratorConfig $config = new GeneratorConfig(),
-        ?AttributeConstraintExtractor $attributeExtractor = null,
+        ?PropertyDataExtractorInterface $propertyDataExtractor = null,
     ) {
-        $this->validationExtractor = $validationExtractor ?? new ValidationConstraintExtractor();
-        $this->attributeExtractor = $attributeExtractor ?? new AttributeConstraintExtractor();
+        // If no extractor is provided, use the default composite with all extractors
+        $this->propertyDataExtractor = $propertyDataExtractor ?? CompositePropertyDataExtractor::createDefault();
     }
 
     /**
@@ -132,15 +129,8 @@ protected function generateProperty(PropertyInterface $property): ?Property
         $type = $property->getType();
         $propertyTypes = $this->extractPropertyTypes($type);
 
-        // Extract validation constraints from PHPDoc (if enabled)
-        $validationRules = [];
-        if ($this->config->enableValidationConstraints) {
-            $validationRules = $this->extractValidationConstraints($property, $propertyTypes);
-            $validationRules = \array_merge(
-                $validationRules,
-                $this->extractAttributeConstraints($property, $propertyTypes),
-            );
-        }
+        // Extract validation constraints using the configurable extractor system
+        $validationRules = $this->extractValidationConstraints($property, $propertyTypes);
 
         return new Property(
             types: $propertyTypes,
@@ -172,32 +162,15 @@ enum: $collectionSimpleType->getEnumValues(),
     }
 
     /**
-     * Extract validation constraints from property PHPDoc
+     * Extract validation constraints from property using the configured extractors.
      */
     private function extractValidationConstraints(PropertyInterface $property, array $propertyTypes): array
     {
         $allValidationRules = [];
 
         foreach ($propertyTypes as $propertyType) {
             if ($propertyType->type instanceof Schema\Type) {
-                $validationRules = $this->validationExtractor->extractValidationRules($property, $propertyType->type);
-                $allValidationRules = \array_merge($allValidationRules, $validationRules);
-            }
-        }
-
-        return $allValidationRules;
-    }
-
-    /**
-     * Extract validation constraints from property attributes
-     */
-    private function extractAttributeConstraints(PropertyInterface $property, array $propertyTypes): array
-    {
-        $allValidationRules = [];
-
-        foreach ($propertyTypes as $propertyType) {
-            if ($propertyType->type instanceof Schema\Type) {
-                $validationRules = $this->attributeExtractor->extractValidationRules($property, $propertyType->type);
+                $validationRules = $this->propertyDataExtractor->extractValidationRules($property, $propertyType->type);
                 $allValidationRules = \array_merge($allValidationRules, $validationRules);
             }
         }

src/GeneratorConfig.php

@@ -13,10 +13,7 @@
 use Spiral\JsonSchemaGenerator\Parser\PropertyInterface;
 use Spiral\JsonSchemaGenerator\Schema\Type;
 
-/**
- * @internal
- */
-final readonly class AttributeConstraintExtractor
+final readonly class AttributeConstraintExtractor implements PropertyDataExtractorInterface
 {
     public function extractValidationRules(PropertyInterface $property, Type $jsonSchemaType): array
     {
@@ -84,7 +81,6 @@ public function extractValidationRules(PropertyInterface $property, Type $jsonSc
     private function getLengthMinKey(Type $jsonSchemaType): string
     {
         return match ($jsonSchemaType) {
-            Type::String => 'minLength',
             Type::Array => 'minItems',
             default => 'minLength', // fallback
         };
@@ -93,7 +89,6 @@ private function getLengthMinKey(Type $jsonSchemaType): string
     private function getLengthMaxKey(Type $jsonSchemaType): string
     {
         return match ($jsonSchemaType) {
-            Type::String => 'maxLength',
             Type::Array => 'maxItems',
             default => 'maxLength', // fallback
         };

src/Validation/AttributeConstraintExtractor.php

@@ -0,0 +1,49 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Spiral\JsonSchemaGenerator\Validation;
+
+use Spiral\JsonSchemaGenerator\Parser\PropertyInterface;
+use Spiral\JsonSchemaGenerator\Schema\Type;
+
+final readonly class CompositePropertyDataExtractor implements PropertyDataExtractorInterface
+{
+    /**
+     * @param list<PropertyDataExtractorInterface> $extractors
+     */
+    public function __construct(
+        private array $extractors = [],
+    ) {}
+
+    /**
+     * Create a default instance with commonly used extractors.
+     */
+    public static function createDefault(): self
+    {
+        return new self([
+            new ValidationConstraintExtractor(),
+            new AttributeConstraintExtractor(),
+        ]);
+    }
+
+    /**
+     * Add an extractor to the composite.
+     */
+    public function withExtractor(PropertyDataExtractorInterface $extractor): self
+    {
+        return new self([...$this->extractors, $extractor]);
+    }
+
+    public function extractValidationRules(PropertyInterface $property, Type $jsonSchemaType): array
+    {
+        $allValidationRules = [];
+
+        foreach ($this->extractors as $extractor) {
+            $validationRules = $extractor->extractValidationRules($property, $jsonSchemaType);
+            $allValidationRules = \array_merge($allValidationRules, $validationRules);
+        }
+
+        return $allValidationRules;
+    }
+}

src/Validation/CompositePropertyDataExtractor.php

@@ -0,0 +1,20 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Spiral\JsonSchemaGenerator\Validation;
+
+use Spiral\JsonSchemaGenerator\Parser\PropertyInterface;
+use Spiral\JsonSchemaGenerator\Schema\Type;
+
+interface PropertyDataExtractorInterface
+{
+    /**
+     * Extract validation rules from a property for a specific JSON schema type.
+     *
+     * @param PropertyInterface $property The property to extract rules from
+     * @param Type $jsonSchemaType The JSON schema type to extract rules for
+     * @return array<string, mixed> Array of validation rules
+     */
+    public function extractValidationRules(PropertyInterface $property, Type $jsonSchemaType): array;
+}

src/Validation/PropertyDataExtractorInterface.php

@@ -7,10 +7,7 @@
 use Spiral\JsonSchemaGenerator\Parser\PropertyInterface;
 use Spiral\JsonSchemaGenerator\Schema\Type;
 
-/**
- * @internal
- */
-final readonly class ValidationConstraintExtractor
+final readonly class ValidationConstraintExtractor implements PropertyDataExtractorInterface
 {
     public function __construct(
         private DocBlockParser $docBlockParser = new DocBlockParser(),