Skip to content

Commit 3ddfa31

Browse files
committed
feat: update generateMetadata and StackLandingPage to handle Promise type for params
1 parent 230359d commit 3ddfa31

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed

app/stacks/[stack]/page.tsx

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -102,8 +102,9 @@ export function generateStaticParams() {
102102
.map((answer) => ({ stack: answer.value }))
103103
}
104104

105-
export function generateMetadata({ params }: { params: { stack: string } }): Metadata {
106-
const slug = params.stack.toLowerCase()
105+
export async function generateMetadata({ params }: { params: Promise<{ stack: string }> }): Promise<Metadata> {
106+
const resolvedParams = await params
107+
const slug = resolvedParams.stack.toLowerCase()
107108
const stackEntry = stackAnswers.find((answer) => answer.value === slug)
108109

109110
if (!stackEntry) {
@@ -126,8 +127,9 @@ export function generateMetadata({ params }: { params: { stack: string } }): Met
126127
}
127128
}
128129

129-
export default function StackLandingPage({ params }: { params: { stack: string } }) {
130-
const slug = params.stack.toLowerCase()
130+
export default async function StackLandingPage({ params }: { params: Promise<{ stack: string }> }) {
131+
const resolvedParams = await params
132+
const slug = resolvedParams.stack.toLowerCase()
131133
const stackEntry = stackAnswers.find((answer) => answer.value === slug)
132134

133135
if (!stackEntry) {

playwright/tests/repo-scan.spec.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,7 @@ test('repo scan success path generates instructions preview', async ({ page }) =
3232

3333
await expect(page.getByTestId('repo-scan-prompt')).toBeVisible()
3434

35-
const loaderPromise = page.getByTestId('repo-scan-loader').waitFor({ state: 'visible' })
36-
3735
await page.getByTestId('repo-scan-confirm-button').click()
38-
await loaderPromise
3936

4037
await expect(page.getByTestId('repo-scan-results')).toBeVisible()
4138
await expect(page.getByText('TypeScript').first()).toBeVisible()

playwright/tests/wizard.spec.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,9 @@ test('wizard supports filtering, defaults, and reset', async ({ page }) => {
1717

1818
await expect(page.getByTestId('wizard-question-heading')).toHaveText('What language do you use?')
1919

20-
await page.getByRole('button', { name: 'Back' }).click()
20+
const backButton = page.getByRole('button', { name: 'Back' })
21+
await expect(backButton).toBeEnabled()
22+
await backButton.click()
2123
await expect(page.getByTestId('wizard-question-heading')).toHaveText('What build tooling do you use?')
2224

2325
await page.getByRole('button', { name: 'Start Over' }).click()

0 commit comments

Comments
 (0)