Add a new flag to spfs clean to prune all tag namespaces

Now that the behavior is to only prune tags in the active tag namespace,
this provides a way to prune all the tags in the repo regardless of what
tag namespace they are in.

Signed-off-by: J Robert Ray <[email protected]>

Author: jrray

crates/spfs-cli/cmd-clean/src/cmd_clean.rs

@@ -50,6 +50,11 @@ pub struct CmdClean {
     #[clap(long)]
     dry_run: bool,
 
+    /// Prune all tag namespaces. The default is to only prune tags in the
+    /// active tag namespace.
+    #[clap(long)]
+    prune_all_tag_namespaces: bool,
+
     /// Prune old tags that have the same target as a more recent version
     #[clap(long = "prune-repeated", group = "repo_data")]
     prune_repeated: bool,
@@ -165,6 +170,7 @@ impl CmdClean {
             .with_reporter(spfs::clean::ConsoleCleanReporter::default())
             .with_dry_run(self.dry_run)
             .with_required_age(chrono::Duration::minutes(15))
+            .with_prune_all_tag_namespaces(self.prune_all_tag_namespaces)
             .with_prune_repeated_tags(prune_repeated_tags)
             .with_prune_tags_older_than(self.prune_if_older_than)
             .with_keep_tags_newer_than(self.keep_if_newer_than)

crates/spfs/src/clean.rs

@@ -46,6 +46,7 @@ where
     attached: DashSet<encoding::Digest>,
     dry_run: bool,
     must_be_older_than: DateTime<Utc>,
+    prune_all_tag_namespaces: bool,
     prune_repeated_tags: Option<NonZero<u64>>,
     prune_params: PruneParameters,
     remove_proxies_with_no_links: bool,
@@ -69,6 +70,7 @@ impl<'repo> Cleaner<'repo, SilentCleanReporter> {
             attached: Default::default(),
             dry_run: false,
             must_be_older_than: Utc::now(),
+            prune_all_tag_namespaces: false,
             prune_repeated_tags: None,
             prune_params: Default::default(),
             remove_proxies_with_no_links: true,
@@ -89,6 +91,7 @@ where
             attached: self.attached,
             dry_run: self.dry_run,
             must_be_older_than: self.must_be_older_than,
+            prune_all_tag_namespaces: self.prune_all_tag_namespaces,
             prune_repeated_tags: self.prune_repeated_tags,
             prune_params: self.prune_params,
             removal_concurrency: self.removal_concurrency,
@@ -155,6 +158,13 @@ where
         self
     }
 
+    /// When walking tags, whether to prune tags in all tag namespaces or only
+    /// the tag namespace configured on the repository.
+    pub fn with_prune_all_tag_namespaces(mut self, prune_all_tag_namespaces: bool) -> Self {
+        self.prune_all_tag_namespaces = prune_all_tag_namespaces;
+        self
+    }
+
     /// When walking the history of a tag, delete older entries
     /// that have the same target as a more recent one.
     pub fn with_prune_repeated_tags(mut self, prune_repeated_tags: Option<NonZero<u64>>) -> Self {
@@ -428,14 +438,15 @@ where
         // still alive, but if the repo passed to the Cleaner has a namespace
         // set on it then one would expect that only tags in that namespace are
         // pruned.
-        let should_prune_this_namespace = match (
-            tag_namespace_to_prune.as_ref(),
-            tag_namespace_to_visit.as_deref(),
-        ) {
-            (Some(prune), Some(visit)) if prune.as_ref() == visit => true,
-            (None, None) => true,
-            _ => false,
-        };
+        let should_prune_this_namespace = self.prune_all_tag_namespaces
+            || match (
+                tag_namespace_to_prune.as_ref(),
+                tag_namespace_to_visit.as_deref(),
+            ) {
+                (Some(prune), Some(visit)) if prune.as_ref() == visit => true,
+                (None, None) => true,
+                _ => false,
+            };
 
         let history = self
             .repo