Convenience conversion from EmbeddedBuildSource to BuildIdent

Signed-off-by: J Robert Ray <[email protected]>

Author: jrray

crates/spk-schema/crates/foundation/src/ident_build/build.rs

@@ -177,6 +177,14 @@ impl std::fmt::Display for Build {
     }
 }
 
+impl TryFrom<String> for Build {
+    type Error = super::Error;
+
+    fn try_from(value: String) -> Result<Self, Self::Error> {
+        Self::from_str(&value)
+    }
+}
+
 impl FromStr for Build {
     type Err = super::Error;
 

crates/spk-schema/crates/foundation/src/version/mod.rs

@@ -554,6 +554,14 @@ impl TryFrom<&str> for Version {
     }
 }
 
+impl TryFrom<String> for Version {
+    type Error = Error;
+
+    fn try_from(value: String) -> Result<Self> {
+        parse_version(value)
+    }
+}
+
 impl FromStr for Version {
     type Err = Error;
 

crates/spk-schema/crates/ident/src/ident_build.rs

@@ -6,7 +6,7 @@ use std::fmt::Write;
 use std::str::FromStr;
 
 use relative_path::RelativePathBuf;
-use spk_schema_foundation::ident_build::Build;
+use spk_schema_foundation::ident_build::{Build, EmbeddedSourcePackage};
 use spk_schema_foundation::ident_ops::parsing::IdentPartsBuf;
 use spk_schema_foundation::ident_ops::{MetadataPath, TagPath};
 use spk_schema_foundation::name::{PkgName, PkgNameBuf, RepositoryNameBuf};
@@ -30,6 +30,34 @@ pub type BuildIdent = Ident<VersionIdent, Build>;
 
 crate::ident_version::version_ident_methods!(BuildIdent, .base);
 
+impl TryFrom<EmbeddedSourcePackage> for BuildIdent {
+    type Error = Error;
+
+    fn try_from(value: EmbeddedSourcePackage) -> std::result::Result<Self, Self::Error> {
+        let IdentPartsBuf {
+            repository_name: _,
+            pkg_name,
+            version_str: Some(version),
+            build_str: Some(build),
+        } = value.ident
+        else {
+            return if value.ident.build_str.is_some() {
+                Err(Error::String(
+                    "EmbeddedSourcePackage missing version".to_string(),
+                ))
+            } else {
+                Err(Error::String(
+                    "EmbeddedSourcePackage missing build".to_string(),
+                ))
+            };
+        };
+        Ok(Self::new(
+            VersionIdent::new(pkg_name.try_into()?, version.try_into()?),
+            build.try_into()?,
+        ))
+    }
+}
+
 macro_rules! build_ident_methods {
     ($Ident:ty $(, .$($access:ident).+)?) => {
         impl $Ident {