Refactor type used for resolvo package names

By using an enum here, the global var handling can use its own enum
variant instead of the flawed string prefix approach. Now it is simply
not possible for a package name to be confused for a global var.

Signed-off-by: J Robert Ray <[email protected]>

Author: jrray

crates/spk-solve/src/cdcl_solver/pkg_request_version_set.rs

@@ -7,6 +7,7 @@ use std::sync::Arc;
 use resolvo::utils::VersionSet;
 use spk_schema::ident::{LocatedBuildIdent, PkgRequest, PreReleasePolicy, RangeIdent, RequestedBy};
 use spk_schema::ident_component::Component;
+use spk_schema::name::OptNameBuf;
 use spk_schema::Request;
 
 /// This allows for storing strings of different types but hash and compare by
@@ -74,7 +75,7 @@ impl std::fmt::Display for VarValue {
 #[derive(Clone, Debug, Eq, Hash, PartialEq)]
 pub(crate) enum RequestVS {
     SpkRequest(Request),
-    GlobalVar { key: String, value: VarValue },
+    GlobalVar { key: OptNameBuf, value: VarValue },
 }
 
 impl std::fmt::Display for RequestVS {
@@ -163,7 +164,7 @@ impl PartialEq<SyntheticComponent> for Component {
 #[derive(Clone, Debug, Eq, Hash, PartialEq)]
 pub(crate) enum SpkSolvable {
     LocatedBuildIdentWithComponent(LocatedBuildIdentWithComponent),
-    GlobalVar { key: String, value: VarValue },
+    GlobalVar { key: OptNameBuf, value: VarValue },
 }
 
 impl std::fmt::Display for SpkSolvable {