Skip to content

Commit 9736326

Browse files
committed
More passing embedded package tests
These tests pass after relaxing the build comparison like the other test. Signed-off-by: J Robert Ray <[email protected]>
1 parent 56728c8 commit 9736326

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

crates/spk-solve/src/solver_test.rs

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1327,8 +1327,6 @@ async fn test_solver_embedded_package_adds_request(#[case] mut solver: SolverImp
13271327

13281328
#[rstest]
13291329
#[case::og(og_solver())]
1330-
// Remove #[should_panic] once cdcl handles this case
1331-
#[should_panic]
13321330
#[case::cdcl(cdcl_solver())]
13331331
#[tokio::test]
13341332
async fn test_solver_embedded_package_solvable(#[case] mut solver: SolverImpl) {
@@ -1361,7 +1359,7 @@ async fn test_solver_embedded_package_solvable(#[case] mut solver: SolverImpl) {
13611359
assert_resolved!(
13621360
solution,
13631361
"qt",
1364-
build = Build::Embedded(EmbeddedSource::Unknown)
1362+
build =~ Build::Embedded(_)
13651363
);
13661364
}
13671365

@@ -1402,7 +1400,6 @@ async fn test_solver_embedded_package_unsolvable(#[case] mut solver: SolverImpl)
14021400

14031401
#[rstest]
14041402
#[case::og(og_solver())]
1405-
#[should_panic]
14061403
#[case::cdcl(cdcl_solver())]
14071404
#[tokio::test]
14081405
async fn test_solver_embedded_package_replaces_real_package(#[case] mut solver: SolverImpl) {
@@ -1458,7 +1455,7 @@ async fn test_solver_embedded_package_replaces_real_package(#[case] mut solver:
14581455
assert_resolved!(
14591456
solution,
14601457
"qt",
1461-
build = Build::Embedded(EmbeddedSource::Unknown)
1458+
build =~ Build::Embedded(_)
14621459
);
14631460
assert_not_resolved!(solution, "unwanted-dep");
14641461
}

0 commit comments

Comments
 (0)