fix issue with ldap entry_dn call

Author: vincentDcmps

supysonic/managers/ldap.py

@@ -44,7 +44,7 @@ def try_auth(self, user, password):
                 return False
         try:
             with ldap3.Connection(
-                self.server, entrie["entry_dn"], password, read_only=True
+                self.server, entrie.entry_dn, password, read_only=True
             ) as conn:
                 return {
                     "uid": entrie[self.username_attr],

tests/managers/test_manager_ldap.py

@@ -14,6 +14,12 @@
     "email_attr": "mail",
 }
 
+class MockEntrie ():
+    def __init__(self,dn,attr):
+        self.entry_dn=dn
+        self.attribute=attr
+    def __getitem__(self, item):
+        return self.attribute[item]
 
 class LdapManagerTestCase(unittest.TestCase):
 
@@ -37,7 +43,7 @@ def test_ldapManager_searchUser(self, mock_object):
     @patch('supysonic.managers.ldap.ldap3.Connection')
     def test_ldapManager_try_auth(self, mock_object):
         mock_object.return_value.__enter__.return_value.entries = [
-            {LDAP["username_attr"]:"toto", "entry_dn":"cn=toto", "mail":"toto@example.com"}]
+            MockEntrie ("cn=toto",{LDAP["username_attr"]:"toto", "mail":"toto@example.com"})]
         ldap = LdapManager(**LDAP)
         ldap_user = ldap.try_auth("toto", "toto")
         self.assertFalse(ldap_user["admin"])

tests/managers/test_manager_user.py

@@ -13,6 +13,7 @@
 from unittest.mock import patch
 import uuid
 
+from .test_manager_ldap import MockEntrie
 
 class UserManagerTestCase(unittest.TestCase):
     def setUp(self):
@@ -149,15 +150,15 @@ def test_try_auth_ldap(self,mock_object):
         config=get_current_config()
         config.LDAP["ldap_server"]="fakeserver"
         mock_object.return_value.__enter__.return_value.entries = [
-            {"uid":"toto", "entry_dn":"cn=toto", "mail":"toto@example.com"}]
+            MockEntrie ("cn=toto",{config.LDAP["username_attr"]:"toto", "mail":"toto@example.com"})]
         authed= UserManager.try_auth('toto','toto')
         user = db.User.get(name="toto")
         self.assertEqual(authed, user)
 
         # test admin and mail change
         config.LDAP["admin_filter"]="fake_admin_filer"
         mock_object.return_value.__enter__.return_value.entries = [
-            {"uid":"toto", "entry_dn":"cn=toto", "mail":"toto2@example.com"}]
+            MockEntrie ("cn=toto",{config.LDAP["username_attr"]:"toto", "mail":"toto2@example.com"})]
         authed= UserManager.try_auth('toto','toto')
         self.assertEqual(authed.mail,"toto2@example.com")
         self.assertEqual(authed.admin,True)