Consider Merging with https://github.com/graycoreio/magento2-cors

[damienwebdev]

Howdy, I was wondering if it would be a good idea to consolidate this project into https://github.com/graycoreio/magento2-cors?

Obviously, if you're still maintaining this, then more power to you :), but I saw #11 and figured I would at least ask.

[thaddeusmt]

I have not had to use this module in a long time, and maintaining it is a bit of a headache, if your module does what this does and more I could "deprecate" this and point folks your way.

[damienwebdev]

Ok -- feel free to do so :)

I can outline a doc on migration, but one of the things that we explicitly don't do (that is breaking from your package) is allow people to configure this behavior from the admin panel.

We explicitly disallow it since all-too-often people mistakenly just read "Access-Control-Allow-Origin: *" on some blog and ignore the ramifications.

We do explain clearly how to describe this configuration in env.php or config.php but that's a different configuration model than yours does out-of-the-box.

[thaddeusmt]

Sorry for the long delay again @damienwebdev -

Given the differences in configuration and functionality I'm not sure of the best way to "consolidate" these projects. You are recommending just adding a short document describing how to swap modules? Having not used your extension I'm not in a great position to write that up, but if you do outline a doc on migration as you said you might, I'll be happy to link over to it (or include it here).

Thanks