additional zero file testing

Existing tests didn't 100% make sure a zero byte file was correctly
added and extracted. It was. Now we also have the tests to prove it.

Author: splitbrain

tests/TarTestCase.php

@@ -545,6 +545,38 @@ public function testZeroData()
         $this->assertEquals(512 * 3, strlen($file)); // 1 header block + 2 footer blocks
     }
 
+    /**
+     * Add a zero byte file to a tar and extract it again
+     */
+    public function testZeroByteFile() {
+        $archive = sys_get_temp_dir() . '/dwziptest' . md5(time()) . '.zip';
+        $extract = sys_get_temp_dir() . '/dwziptest' . md5(time() + 1);
+
+        $tar = new Tar();
+        $tar->create($archive);
+        $tar->addFile(__DIR__ . '/zip/zero.txt', 'foo/zero.txt');
+        $tar->close();
+        $this->assertFileExists($archive);
+
+        $tar = new Tar();
+        $tar->open($archive);
+        $contents = $tar->contents();
+
+        $this->assertEquals(1, count($contents));
+        $this->assertEquals('foo/zero.txt', ($contents[0])->getPath());
+
+        $tar = new Tar();
+        $tar->open($archive);
+        $tar->extract($extract);
+        $tar->close();
+
+        $this->assertFileExists("$extract/foo/zero.txt");
+        $this->assertEquals(0, filesize("$extract/foo/zero.txt"));
+
+        self::RDelete($extract);
+        unlink($archive);
+    }
+
     /**
      * A file of exactly one block should be just a header block + data block + the footer
      */

tests/ZipTestCase.php

@@ -226,6 +226,38 @@ public function testDogFood()
         unlink($archive);
     }
 
+    /**
+     * Add a zero byte file to a zip and extract it again
+     */
+    public function testZeroByteFile() {
+        $archive = sys_get_temp_dir() . '/dwziptest' . md5(time()) . '.zip';
+        $extract = sys_get_temp_dir() . '/dwziptest' . md5(time() + 1);
+
+        $zip = new Zip();
+        $zip->create($archive);
+        $zip->addFile(__DIR__ . '/zip/zero.txt', 'foo/zero.txt');
+        $zip->close();
+        $this->assertFileExists($archive);
+
+        $zip = new Zip();
+        $zip->open($archive);
+        $contents = $zip->contents();
+
+        $this->assertEquals(1, count($contents));
+        $this->assertEquals('foo/zero.txt', ($contents[0])->getPath());
+
+        $zip = new Zip();
+        $zip->open($archive);
+        $zip->extract($extract);
+        $zip->close();
+
+        $this->assertFileExists("$extract/foo/zero.txt");
+        $this->assertEquals(0, filesize("$extract/foo/zero.txt"));
+
+        self::RDelete($extract);
+        unlink($archive);
+    }
+
     /**
      * @depends testExtZipIsInstalled
      */