Fix region detection logic (#741)

lizardoluis · web-flow · commit d24aecd491eb · 2024-11-19T13:59:19.000+01:00
diff --git a/object_store_factory/src/aws.rs b/object_store_factory/src/aws.rs
@@ -205,7 +205,7 @@ pub async fn add_amazon_s3_specific_options(
     url: &Url,
     options: &mut HashMap<AmazonS3ConfigKey, String>,
 ) {
-    if !options.contains_key(&AmazonS3ConfigKey::Bucket)
+    if !options.contains_key(&AmazonS3ConfigKey::Region)
         && !options.contains_key(&AmazonS3ConfigKey::Endpoint)
     {
         let region = detect_region(url).await.unwrap();

Original file line number	Diff line number	Diff line change
`@@ -205,7 +205,7 @@ pub async fn add_amazon_s3_specific_options(`
`205`	`205`	`url: &Url,`
`206`	`206`	`options: &mut HashMap<AmazonS3ConfigKey, String>,`
`207`	`207`	`) {`
`208`		`- if !options.contains_key(&AmazonS3ConfigKey::Bucket)`
	`208`	`+ if !options.contains_key(&AmazonS3ConfigKey::Region)`
`209`	`209`	`&& !options.contains_key(&AmazonS3ConfigKey::Endpoint)`
`210`	`210`	`{`
`211`	`211`	`let region = detect_region(url).await.unwrap();`