Skip to content

Commit 009c558

Browse files
Polishing
1 parent 5b46ea3 commit 009c558

File tree

4 files changed

+20
-18
lines changed

4 files changed

+20
-18
lines changed

splitio_web/lib/splitio_web.dart

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,15 +33,15 @@ class SplitioWeb extends SplitioPlatform {
3333
required String matchingKey,
3434
required String? bucketingKey,
3535
SplitConfiguration? sdkConfiguration,
36-
}) async {
36+
}) {
3737
if (_initFuture == null) {
3838
_initFuture = this._init(
3939
apiKey: apiKey,
4040
matchingKey: matchingKey,
4141
bucketingKey: bucketingKey,
4242
sdkConfiguration: sdkConfiguration);
4343
}
44-
return _initFuture;
44+
return _initFuture!;
4545
}
4646

4747
Future<void> _init({
@@ -92,7 +92,8 @@ class SplitioWeb extends SplitioPlatform {
9292
// Create and inject script tag
9393
final script = document.createElement('script') as HTMLScriptElement;
9494
script.type = 'text/javascript';
95-
script.src = 'assets/packages/splitio_web/web/split-browser-1.6.0.full.min.js';
95+
script.src =
96+
'assets/packages/splitio_web/web/split-browser-1.6.0.full.min.js';
9697

9798
// Wait for script to load
9899
final completer = Completer<void>();

splitio_web/lib/src/js_interop.dart

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -316,18 +316,6 @@ JSAny buildJsKey(String matchingKey, String? bucketingKey) {
316316
return matchingKey.toJS;
317317
}
318318

319-
({String matchingKey, String? bucketingKey}) buildDartKey(JSAny splitKey) {
320-
return splitKey is JSString
321-
? (matchingKey: splitKey.toDart, bucketingKey: null)
322-
: (
323-
matchingKey:
324-
(reflectGet(splitKey as JSObject, 'matchingKey'.toJS) as JSString)
325-
.toDart,
326-
bucketingKey:
327-
(reflectGet(splitKey, 'bucketingKey'.toJS) as JSString).toDart,
328-
);
329-
}
330-
331319
String buildKeyString(String matchingKey, String? bucketingKey) {
332320
return bucketingKey == null ? matchingKey : '${matchingKey}_$bucketingKey';
333321
}

splitio_web/test/splitio_web_test.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -701,8 +701,7 @@ void main() {
701701
eventsEndpoint: 'https://events.domain/api',
702702
authServiceEndpoint: 'https://auth.domain/api/v2',
703703
streamingServiceEndpoint: 'https://streaming.domain/sse',
704-
telemetryServiceEndpoint:
705-
'https://telemetry.domain/api/v1',
704+
telemetryServiceEndpoint: 'https://telemetry.domain/api/v1',
706705
syncConfig: SyncConfig(
707706
names: ['flag_1', 'flag_2'], prefixes: ['prefix_1']),
708707
impressionsMode: ImpressionsMode.none,
@@ -1062,7 +1061,8 @@ void main() {
10621061
await Future<void>.delayed(Duration.zero); // onResume is async
10631062
mockClient.emit(mockClient.Event.SDK_UPDATE);
10641063

1065-
await Future<void>.delayed(Duration.zero); // let last event deliver before cancel
1064+
await Future<void>.delayed(
1065+
Duration.zero); // let last event deliver before cancel
10661066
await subscription.cancel();
10671067
});
10681068
});

splitio_web/test/utils/js_interop_test_utils.dart

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,19 @@ external JSPromise<Null> _promiseResolve();
77
@JS('Object.assign')
88
external JSObject _objectAssign(JSObject target, JSObject source);
99

10+
// Not WASM-compatible. Currently used only in tests
11+
({String matchingKey, String? bucketingKey}) buildDartKey(JSAny splitKey) {
12+
return splitKey is JSString
13+
? (matchingKey: splitKey.toDart, bucketingKey: null)
14+
: (
15+
matchingKey:
16+
(reflectGet(splitKey as JSObject, 'matchingKey'.toJS) as JSString)
17+
.toDart,
18+
bucketingKey:
19+
(reflectGet(splitKey, 'bucketingKey'.toJS) as JSString).toDart,
20+
);
21+
}
22+
1023
class SplitioMock {
1124
// JS Browser SDK API mock
1225
final JS_BrowserSDKPackage splitio = JSObject() as JS_BrowserSDKPackage;

0 commit comments

Comments
 (0)