Skip to content

Commit 0e4853b

Browse files
Rename FallbackTreatments to FallbackTreatmentsConfiguration
1 parent 52a8cf8 commit 0e4853b

File tree

4 files changed

+35
-15
lines changed

4 files changed

+35
-15
lines changed

splitio_platform_interface/lib/split_configuration.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import 'package:splitio_platform_interface/split_certificate_pinning_configuration.dart';
2-
import 'package:splitio_platform_interface/split_fallback_treatments.dart';
2+
import 'package:splitio_platform_interface/split_fallback_treatments_configuration.dart';
33
import 'package:splitio_platform_interface/split_sync_config.dart';
44
import 'package:splitio_platform_interface/split_rollout_cache_configuration.dart';
55

@@ -81,7 +81,7 @@ class SplitConfiguration {
8181
int? readyTimeout = 10,
8282
CertificatePinningConfiguration? certificatePinningConfiguration,
8383
RolloutCacheConfiguration? rolloutCacheConfiguration,
84-
FallbackTreatments? fallbackTreatments,
84+
FallbackTreatmentsConfiguration? fallbackTreatments,
8585
}) {
8686
if (featuresRefreshRate != null) {
8787
configurationMap['featuresRefreshRate'] = featuresRefreshRate;

splitio_platform_interface/lib/split_fallback_treatments.dart renamed to splitio_platform_interface/lib/split_fallback_treatments_configuration.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
import 'package:splitio_platform_interface/split_result.dart';
22

3-
class FallbackTreatments {
3+
class FallbackTreatmentsConfiguration {
44
late Map<String, String?>? _global;
55
late Map<String, Map<String, String?>>? _byFlag;
66

77
Map<String, String?>? get global => _global;
88
Map<String, Map<String, String?>>? get byFlag => _byFlag;
99

10-
FallbackTreatments(
10+
FallbackTreatmentsConfiguration(
1111
{SplitResult? global, Map<String, SplitResult>? byFlag}) {
1212
_global = global != null
1313
? {'treatment': global.treatment, 'config': global.config}

splitio_platform_interface/test/split_fallback_treatments_test.dart renamed to splitio_platform_interface/test/split_fallback_treatments_configuration_test.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,21 @@
11
import 'package:flutter_test/flutter_test.dart';
2-
import 'package:splitio_platform_interface/split_fallback_treatments.dart';
2+
import 'package:splitio_platform_interface/split_fallback_treatments_configuration.dart';
33
import 'package:splitio_platform_interface/split_result.dart';
44

55
void main() {
66
test('global and by flag fallback treatments', () {
7-
var config = FallbackTreatments(global: const SplitResult('custom-treatment', null));
7+
var config = FallbackTreatmentsConfiguration(global: const SplitResult('custom-treatment', null));
88

99
expect(config.global, equals({'treatment': 'custom-treatment', 'config': null}));
1010
expect(config.byFlag, null);
1111

12-
config = FallbackTreatments(byFlag: {'flag1': const SplitResult('custom-treatment', 'custom-config')});
12+
config = FallbackTreatmentsConfiguration(byFlag: {'flag1': const SplitResult('custom-treatment', 'custom-config')});
1313
expect(config.byFlag, equals({'flag1': {'treatment': 'custom-treatment', 'config': 'custom-config'}}));
1414
expect(config.global, null);
1515
});
1616

1717
test('default values', () {
18-
var config = FallbackTreatments();
18+
var config = FallbackTreatmentsConfiguration();
1919

2020
expect(config.global, null);
2121
expect(config.byFlag, null);

splitio_platform_interface/test/splitio_configuration_test.dart

Lines changed: 27 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import 'package:flutter_test/flutter_test.dart';
22
import 'package:splitio_platform_interface/split_certificate_pinning_configuration.dart';
33
import 'package:splitio_platform_interface/split_configuration.dart';
4-
import 'package:splitio_platform_interface/split_fallback_treatments.dart';
4+
import 'package:splitio_platform_interface/split_fallback_treatments_configuration.dart';
55
import 'package:splitio_platform_interface/split_result.dart';
66
import 'package:splitio_platform_interface/split_rollout_cache_configuration.dart';
77
import 'package:splitio_platform_interface/split_sync_config.dart';
@@ -38,8 +38,16 @@ void main() {
3838
.addPin('host1', 'pin1')
3939
.addPin('host2', 'pin3')
4040
.addPin('host1', 'pin2'),
41-
rolloutCacheConfiguration: RolloutCacheConfiguration(expirationDays: 15, clearOnInit: true),
42-
fallbackTreatments: FallbackTreatments(global: const SplitResult('custom-treatment', null)));
41+
rolloutCacheConfiguration:
42+
RolloutCacheConfiguration(expirationDays: 15, clearOnInit: true),
43+
fallbackTreatments: FallbackTreatmentsConfiguration(
44+
global: const SplitResult('custom-treatment', null),
45+
byFlag: {
46+
'flag1':
47+
const SplitResult('custom-treatment-flag1', 'config-flag1'),
48+
'flag2': const SplitResult('custom-treatment-flag2', null),
49+
},
50+
));
4351

4452
expect(config.configurationMap['eventFlushInterval'], 2000);
4553
expect(config.configurationMap['eventsPerPush'], 300);
@@ -76,10 +84,22 @@ void main() {
7684
'host1': ['pin1', 'pin2'],
7785
'host2': ['pin3']
7886
});
79-
expect(config.configurationMap['rolloutCacheConfiguration']['expirationDays'], 15);
80-
expect(config.configurationMap['rolloutCacheConfiguration']['clearOnInit'], true);
81-
expect(config.configurationMap['fallbackTreatmentsConfiguration']['global'], equals({'treatment': 'custom-treatment', 'config': null}));
82-
expect(config.configurationMap['fallbackTreatmentsConfiguration']['byFlag'], null);
87+
expect(
88+
config.configurationMap['rolloutCacheConfiguration']['expirationDays'],
89+
15);
90+
expect(config.configurationMap['rolloutCacheConfiguration']['clearOnInit'],
91+
true);
92+
expect(config.configurationMap['fallbackTreatments']['global'],
93+
equals({'treatment': 'custom-treatment', 'config': null}));
94+
expect(
95+
config.configurationMap['fallbackTreatments']['byFlag'],
96+
equals({
97+
'flag1': {
98+
'treatment': 'custom-treatment-flag1',
99+
'config': 'config-flag1'
100+
},
101+
'flag2': {'treatment': 'custom-treatment-flag2', 'config': null}
102+
}));
83103
});
84104

85105
test('no special values leaves map empty', () async {

0 commit comments

Comments
 (0)