Skip to content

Commit 1db9d7b

Browse files
Merge branch 'development' into FME-12349-fallback-treatments_baseline
2 parents 4ebc22c + d784655 commit 1db9d7b

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

splitio/lib/splitio.dart

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,11 @@ class Splitio {
7777
ClientReadinessCallback? onReadyFromCache,
7878
ClientReadinessCallback? onUpdated,
7979
ClientReadinessCallback? onTimeout}) {
80-
String? key = matchingKey ?? _defaultMatchingKey;
80+
String key = matchingKey ?? _defaultMatchingKey;
81+
if (matchingKey == null && bucketingKey == null) {
82+
bucketingKey = _defaultBucketingKey;
83+
}
84+
8185
_platform.getClient(matchingKey: key, bucketingKey: bucketingKey);
8286

8387
var client = DefaultSplitClient(_platform, key, bucketingKey);

splitio/test/splitio_platform_stub.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import 'package:plugin_platform_interface/plugin_platform_interface.dart';
22
import 'package:splitio_platform_interface/splitio_platform_interface.dart';
3-
import 'package:splitio_platform_interface/split_evaluation_options.dart';
43

54
class SplitioPlatformStub
65
with MockPlatformInterfaceMixin

splitio_platform_interface/lib/split_impression.dart

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,9 @@ class Impression {
1313
this.appliedRule, this.changeNumber, this.attributes, this.properties);
1414

1515
static Impression fromMap(Map<dynamic, dynamic> map) {
16-
var properties = null;
16+
Map<String, dynamic>? properties;
1717
if (map['properties'] != null) {
1818
properties = Map<String, dynamic>.from(map['properties'] as Map);
19-
} else {
20-
properties = null;
2119
}
2220
return Impression(
2321
map['key'] as String?,

0 commit comments

Comments
 (0)