Remove callAsFunction from logger factory methods. Add test for Logger modules.

Author: EmilianoSanchez

splitio_web/lib/splitio_web.dart

@@ -241,33 +241,35 @@ class SplitioWeb extends SplitioPlatform {
 
       final logLevel = configuration.configurationMap['logLevel'];
       if (logLevel is String) {
-        JSAny? logger;
         switch (SplitLogLevel.values.firstWhere((e) => e.name == logLevel)) {
           case SplitLogLevel.verbose:
           case SplitLogLevel.debug:
-            logger = window.splitio!.DebugLogger?.callAsFunction();
+            config.debug = window.splitio!.DebugLogger != null
+                ? window.splitio!.DebugLogger!()
+                : 'DEBUG'.toJS;
             break;
           case SplitLogLevel.info:
-            logger = window.splitio!.InfoLogger?.callAsFunction();
+            config.debug = window.splitio!.InfoLogger != null
+                ? window.splitio!.InfoLogger!()
+                : 'INFO'.toJS;
             break;
           case SplitLogLevel.warning:
-            logger = window.splitio!.WarnLogger?.callAsFunction();
+            config.debug = window.splitio!.WarnLogger != null
+                ? window.splitio!.WarnLogger!()
+                : 'WARNING'.toJS;
             break;
           case SplitLogLevel.error:
-            logger = window.splitio!.ErrorLogger?.callAsFunction();
+            config.debug = window.splitio!.ErrorLogger != null
+                ? window.splitio!.ErrorLogger!()
+                : 'ERROR'.toJS;
             break;
           default:
             break;
         }
-        if (logger != null) {
-          config.debug = logger; // Browser SDK
-        } else {
-          config.debug = logLevel.toUpperCase().toJS; // JS SDK
-        }
       } else if (configuration.configurationMap['enableDebug'] == true) {
         config.debug = window.splitio!.DebugLogger != null
-            ? window.splitio!.DebugLogger!.callAsFunction() // Browser SDK
-            : 'DEBUG'.toJS; // JS SDK
+            ? window.splitio!.DebugLogger!()
+            : 'DEBUG'.toJS;
       }
 
       if (configuration.configurationMap['readyTimeout'] != null) {

splitio_web/lib/src/js_interop.dart

@@ -26,7 +26,7 @@ extension type JS_ImpressionData._(JSObject _) implements JSObject {
 }
 
 @JS()
-extension type JS_Logger._(JSObject _) implements JSObject {
+extension type JS_ILogger._(JSObject _) implements JSObject {
   external JSAny? debug(JSString message);
   external JSAny? info(JSString message);
   external JSAny? warn(JSString message);
@@ -106,7 +106,7 @@ extension type JS_Configuration._(JSObject _) implements JSObject {
 
 @JS()
 extension type JS_ISettings._(JSObject _) implements JS_Configuration {
-  external JS_Logger log;
+  external JS_ILogger log;
   external JS_IImpressionListener? impressionListener;
 }
 
@@ -215,14 +215,19 @@ extension type JS_IBrowserSDK._(JSObject _) implements JSObject {
   external JS_IUserConsentAPI UserConsent;
 }
 
+@JS()
+extension type JS_LoggerFactory._(JSFunction _) implements JSFunction {
+  external JSObject call();
+}
+
 @JS()
 extension type JS_BrowserSDKPackage._(JSObject _) implements JSObject {
   external JS_IBrowserSDK SplitFactory(JS_Configuration config);
   external JSFunction? InLocalStorage;
-  external JSFunction? DebugLogger;
-  external JSFunction? InfoLogger;
-  external JSFunction? WarnLogger;
-  external JSFunction? ErrorLogger;
+  external JS_LoggerFactory? DebugLogger;
+  external JS_LoggerFactory? InfoLogger;
+  external JS_LoggerFactory? WarnLogger;
+  external JS_LoggerFactory? ErrorLogger;
 }
 
 // Conversion utils: JS to Dart types
@@ -234,7 +239,7 @@ external JSArray<JSString> objectKeys(JSObject obj);
 external JSAny? reflectGet(JSObject target, JSAny propertyKey);
 
 @JS('Reflect.set')
-external JSAny? reflectSet(JSObject target, JSAny propertyKey, JSAny value);
+external JSAny? reflectSet(JSObject target, JSAny propertyKey, JSAny? value);
 
 @JS('JSON.parse')
 external JSObject jsonParse(JSString obj);

splitio_web/test/splitio_web_test.dart

@@ -838,6 +838,49 @@ void main() {
             'storage': {'type': 'LOCALSTORAGE'}
           }));
     });
+
+    test(
+        'init with InLocalStorage and Logger factory modules (Browser SDK full CDN)',
+        () async {
+      mock.addFactoryModules();
+      SplitioWeb _platform = SplitioWeb();
+
+      await _platform.init(
+          apiKey: 'api-key',
+          matchingKey: 'matching-key',
+          bucketingKey: 'bucketing-key',
+          sdkConfiguration: SplitConfiguration(
+              logLevel: SplitLogLevel.info,
+              rolloutCacheConfiguration: RolloutCacheConfiguration(
+                expirationDays: 100,
+                clearOnInit: true,
+              )));
+
+      expect(mock.calls[mock.calls.length - 2].methodName, 'InfoLogger');
+
+      expect(mock.calls.last.methodName, 'SplitFactory');
+      expect(
+          jsAnyToDart(mock.calls.last.methodArguments[0]),
+          equals({
+            'core': {
+              'authorizationKey': 'api-key',
+              'key': {
+                'matchingKey': 'matching-key',
+                'bucketingKey': 'bucketing-key',
+              },
+            },
+            'startup': {
+              'readyTimeout': 10,
+            },
+            'scheduler': {},
+            'urls': {},
+            'sync': {},
+            'debug': {},
+            'storage': {'type': 'LOCALSTORAGE', 'expirationDays': 100, 'clearOnInit': true }
+          }));
+
+      mock.removeFactoryModules();
+    });
   });
 
   group('client', () {

splitio_web/test/utils/js_interop_test_utils.dart

@@ -77,7 +77,7 @@ class SplitioMock {
           return ['split1'.toJS, 'split2'.toJS].jsify();
         }.toJS);
 
-    final mockLog = JSObject() as JS_Logger;
+    final mockLog = JSObject() as JS_ILogger;
     reflectSet(
         mockLog,
         'warn'.toJS,
@@ -397,4 +397,42 @@ class SplitioMock {
 
     return mockClient;
   }
+
+  void addFactoryModules() {
+    reflectSet(
+        splitio,
+        'DebugLogger'.toJS,
+        () {
+          calls.add((methodName: 'DebugLogger', methodArguments: []));
+          return JSObject();
+        }.toJS);
+    reflectSet(
+        splitio,
+        'InfoLogger'.toJS,
+        () {
+          calls.add((methodName: 'InfoLogger', methodArguments: []));
+          return JSObject();
+        }.toJS);
+    reflectSet(
+        splitio,
+        'WarnLogger'.toJS,
+        () {
+          calls.add((methodName: 'WarnLogger', methodArguments: []));
+          return JSObject();
+        }.toJS);
+    reflectSet(
+        splitio,
+        'ErrorLogger'.toJS,
+        () {
+          calls.add((methodName: 'ErrorLogger', methodArguments: []));
+          return JSObject();
+        }.toJS);
+  }
+
+  void removeFactoryModules() {
+    reflectSet(splitio, 'DebugLogger'.toJS, null);
+    reflectSet(splitio, 'InfoLogger'.toJS, null);
+    reflectSet(splitio, 'WarnLogger'.toJS, null);
+    reflectSet(splitio, 'ErrorLogger'.toJS, null);
+  }
 }