Skip to content

Commit 7f1e85e

Browse files
Update tests
1 parent 9c2a423 commit 7f1e85e

File tree

6 files changed

+24
-17
lines changed

6 files changed

+24
-17
lines changed

src/__tests__/browserSuites/manager.spec.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ export default async function (settings, fetchMock, assert) {
4242
'configs': mockSplits.ff.d[index].configurations || {},
4343
'sets': mockSplits.ff.d[index].sets || [],
4444
'defaultTreatment': mockSplits.ff.d[index].defaultTreatment,
45-
'impressionsDisabled': false
45+
'impressionsDisabled': false,
46+
'prerequisites': []
4647
});
4748

4849
assert.equal(manager.split('non_existent'), null, 'Trying to get a manager.split() of a Split that does not exist returns null.');

src/__tests__/consumer/node_redis.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ const expectedImpressionCount = [
6161
];
6262

6363
const expectedSplitName = 'hierarchical_splits_testing_on';
64-
const expectedSplitView = { name: 'hierarchical_splits_testing_on', trafficType: 'user', killed: false, changeNumber: 1487277320548, treatments: ['on', 'off'], configs: {}, sets: [], defaultTreatment: 'off', impressionsDisabled: false };
64+
const expectedSplitView = { name: 'hierarchical_splits_testing_on', trafficType: 'user', killed: false, changeNumber: 1487277320548, treatments: ['on', 'off'], configs: {}, sets: [], defaultTreatment: 'off', impressionsDisabled: false, prerequisites: [] };
6565

6666
const MOCKS = {
6767
'': 'redis-commands',

src/__tests__/nodeSuites/manager.spec.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,8 @@ export default async function (settings, fetchMock, assert) {
4141
'configs': mockSplits.ff.d[index].configurations || {},
4242
'sets': mockSplits.ff.d[index].sets || [],
4343
'defaultTreatment': mockSplits.ff.d[index].defaultTreatment,
44-
'impressionsDisabled': false
44+
'impressionsDisabled': false,
45+
'prerequisites': []
4546
});
4647

4748
assert.equal(manager.split('non_existent'), null, 'Trying to get a manager.split() of a Split that does not exist returns null.');

src/__tests__/offline/browser.spec.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -168,10 +168,10 @@ tape('Browser offline mode', function (assert) {
168168

169169
// Manager tests
170170
const expectedSplitView1 = {
171-
name: 'testing_split', trafficType: 'localhost', killed: false, changeNumber: 0, treatments: ['on'], configs: {}, defaultTreatment: 'control', sets: [], impressionsDisabled: false
171+
name: 'testing_split', trafficType: 'localhost', killed: false, changeNumber: 0, treatments: ['on'], configs: {}, defaultTreatment: 'control', sets: [], impressionsDisabled: false, prerequisites: []
172172
};
173173
const expectedSplitView2 = {
174-
name: 'testing_split_with_config', trafficType: 'localhost', killed: false, changeNumber: 0, treatments: ['off'], configs: { off: '{ "color": "blue" }' }, defaultTreatment: 'control', sets: [], impressionsDisabled: false
174+
name: 'testing_split_with_config', trafficType: 'localhost', killed: false, changeNumber: 0, treatments: ['off'], configs: { off: '{ "color": "blue" }' }, defaultTreatment: 'control', sets: [], impressionsDisabled: false, prerequisites: []
175175
};
176176
assert.deepEqual(manager.names(), ['testing_split', 'testing_split_with_config']);
177177
assert.deepEqual(manager.split('testing_split'), expectedSplitView1);
@@ -282,7 +282,7 @@ tape('Browser offline mode', function (assert) {
282282

283283
// Manager tests
284284
const expectedSplitView3 = {
285-
name: 'testing_split_with_config', trafficType: 'localhost', killed: false, changeNumber: 0, treatments: ['nope'], configs: {}, defaultTreatment: 'control', sets: [], impressionsDisabled: false
285+
name: 'testing_split_with_config', trafficType: 'localhost', killed: false, changeNumber: 0, treatments: ['nope'], configs: {}, defaultTreatment: 'control', sets: [], impressionsDisabled: false, prerequisites: []
286286
};
287287
assert.deepEqual(manager.names(), ['testing_split', 'testing_split_2', 'testing_split_3', 'testing_split_with_config']);
288288
assert.deepEqual(manager.split('testing_split'), expectedSplitView1);

src/__tests__/offline/node.spec.js

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -250,17 +250,17 @@ function ManagerDotSplitTests(assert) {
250250
const expectedView1 = {
251251
name: 'testing_split', changeNumber: 0, killed: false, trafficType: 'localhost',
252252
treatments: ['on'], configs: {}, defaultTreatment: 'control',
253-
sets: [], impressionsDisabled: false
253+
sets: [], impressionsDisabled: false, prerequisites: []
254254
};
255255
const expectedView2 = {
256256
name: 'testing_split2', changeNumber: 0, killed: false, trafficType: 'localhost',
257257
treatments: ['off'], configs: {}, defaultTreatment: 'control',
258-
sets: [], impressionsDisabled: false
258+
sets: [], impressionsDisabled: false, prerequisites: []
259259
};
260260
const expectedView3 = {
261261
name: 'testing_split3', changeNumber: 0, killed: false, trafficType: 'localhost',
262262
treatments: ['custom_treatment'], configs: {}, defaultTreatment: 'control',
263-
sets: [], impressionsDisabled: false
263+
sets: [], impressionsDisabled: false, prerequisites: []
264264
};
265265

266266
assert.deepEqual(manager.split('testing_split'), expectedView1);
@@ -295,7 +295,8 @@ function ManagerDotYamlTests(mockFileName, assert) {
295295
configs: {},
296296
sets: [],
297297
defaultTreatment: 'control',
298-
impressionsDisabled: false
298+
impressionsDisabled: false,
299+
prerequisites: []
299300
};
300301
const expectedView2 = {
301302
name: 'testing_split_only_wl',
@@ -306,7 +307,8 @@ function ManagerDotYamlTests(mockFileName, assert) {
306307
configs: {},
307308
sets: [],
308309
defaultTreatment: 'control',
309-
impressionsDisabled: false
310+
impressionsDisabled: false,
311+
prerequisites: []
310312
};
311313
const expectedView3 = {
312314
name: 'testing_split_with_wl',
@@ -320,7 +322,8 @@ function ManagerDotYamlTests(mockFileName, assert) {
320322
},
321323
sets: [],
322324
defaultTreatment: 'control',
323-
impressionsDisabled: false
325+
impressionsDisabled: false,
326+
prerequisites: []
324327
};
325328
const expectedView4 = {
326329
name: 'testing_split_off_with_config',
@@ -333,7 +336,8 @@ function ManagerDotYamlTests(mockFileName, assert) {
333336
},
334337
sets: [],
335338
defaultTreatment: 'control',
336-
impressionsDisabled: false
339+
impressionsDisabled: false,
340+
prerequisites: []
337341
};
338342

339343
assert.deepEqual(manager.split('testing_split_on'), expectedView1);
@@ -414,15 +418,15 @@ function MultipleInstancesTests(assert) {
414418

415419
const expectedView1 = {
416420
name: 'testing_split', changeNumber: 0, killed: false, trafficType: 'localhost',
417-
treatments: ['on'], configs: {}, sets: [], impressionsDisabled: false
421+
treatments: ['on'], configs: {}, sets: [], impressionsDisabled: false, prerequisites: []
418422
};
419423
const expectedView2 = {
420424
name: 'testing_split2', changeNumber: 0, killed: false, trafficType: 'localhost',
421-
treatments: ['off'], configs: {}, sets: [], impressionsDisabled: false
425+
treatments: ['off'], configs: {}, sets: [], impressionsDisabled: false, prerequisites: []
422426
};
423427
const expectedView3 = {
424428
name: 'testing_split3', changeNumber: 0, killed: false, trafficType: 'localhost',
425-
treatments: ['custom_treatment'], configs: {}, sets: [], impressionsDisabled: false
429+
treatments: ['custom_treatment'], configs: {}, sets: [], impressionsDisabled: false, prerequisites: []
426430
};
427431

428432
assert.deepEqual(manager.split('testing_split'), expectedView1);

ts-tests/index.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,8 @@ splitView = {
143143
},
144144
sets: ['set_a', 'set_b'],
145145
defaultTreatment: 'off',
146-
impressionsDisabled: false
146+
impressionsDisabled: false,
147+
prerequisites: [{ flagName: 'flag1', treatments: ['on'] }]
147148
};
148149
splitViews = [splitView];
149150

0 commit comments

Comments
 (0)