Skip to content

Commit 375e8d5

Browse files
Update flush method return value to Promise<void>
1 parent eefab0b commit 375e8d5

File tree

5 files changed

+5
-5
lines changed

5 files changed

+5
-5
lines changed

CHANGES.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
2.10.1 (December 18, 2025)
2-
- Bugfix - Handle `null` prerequisites properly
2+
- Bugfix - Handle `null` prerequisites properly.
33

44
2.10.0 (December 16, 2025)
55
- Added property `impressionsDisabled` in getTreatment(s) `evaluationOptions` parameter, to disable impressions per evaluations.

src/readiness/readinessManager.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ export function readinessManagerFactory(
162162
isTimedout() { return hasTimedout && !isReady; },
163163
hasTimedout() { return hasTimedout; },
164164
isDestroyed() { return isDestroyed; },
165-
isOperational() { return (isReady || isReadyFromCache) && !isDestroyed; },
165+
isOperational() { return isReadyFromCache && !isDestroyed; },
166166
lastUpdate() { return lastUpdate; }
167167
};
168168

src/sync/polling/updaters/segmentChangesUpdater.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ export function segmentChangesUpdaterFactory(
3737

3838
function updateSegment(segmentName: string, noCache?: boolean, till?: number, fetchOnlyNew?: boolean, retries?: number): Promise<boolean> {
3939
log.debug(`${LOG_PREFIX_SYNC_SEGMENTS}Processing segment ${segmentName}`);
40-
let sincePromise = Promise.resolve(segments.getChangeNumber(segmentName));
40+
const sincePromise = Promise.resolve(segments.getChangeNumber(segmentName));
4141

4242
return sincePromise.then(since => {
4343
// if fetchOnlyNew flag, avoid processing already fetched segments

src/sync/syncManagerOnline.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ export function syncManagerOnlineFactory(
145145
},
146146

147147
flush() {
148-
return submitterManager.execute(!isConsentGranted(settings));
148+
return submitterManager.execute(!isConsentGranted(settings)).then(() => {});
149149
},
150150

151151
// [Only used for client-side]

src/sync/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ export interface ISyncTask<Input extends any[] = [], Output = any> extends ITask
3737
/** SyncManager */
3838

3939
export interface ISyncManager extends ITask {
40-
flush(): Promise<any>,
40+
flush(): Promise<void>,
4141
pushManager?: IPushManager,
4242
pollingManager?: IPollingManager,
4343
submitterManager?: ISubmitterManager

0 commit comments

Comments
 (0)