Skip to content

Commit 4746698

Browse files
Update submitterManager.execute return type to Promise<void>
1 parent 52b14aa commit 4746698

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

src/sync/__tests__/syncTask.mock.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
export function syncTaskFactory() {
22
return {
3-
execute: jest.fn(() => Promise.resolve(true)),
3+
execute: jest.fn(),
44
isExecuting: jest.fn(),
55
start: jest.fn(),
66
stop: jest.fn(),

src/sync/submitters/submitterManager.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ export function submitterManagerFactory(params: ISdkFactoryContextSync): ISubmit
3838
execute(onlyTelemetry?: boolean) {
3939
const promises = onlyTelemetry ? [] : submitters.map(submitter => submitter.execute());
4040
if (telemetrySubmitter) promises.push(telemetrySubmitter.execute());
41-
return Promise.all(promises);
41+
return Promise.all(promises).then(() => { });
4242
},
4343

4444
isExecuting() {

src/sync/submitters/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,5 +237,5 @@ export type TelemetryConfigStatsPayload = TelemetryConfigStats & {
237237
export interface ISubmitterManager extends ISyncTask {
238238
start(onlyTelemetry?: boolean): void,
239239
stop(allExceptTelemetry?: boolean): void,
240-
execute(onlyTelemetry?: boolean): Promise<any>
240+
execute(onlyTelemetry?: boolean): Promise<void>
241241
}

src/sync/syncManagerOnline.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ export function syncManagerOnlineFactory(
145145
},
146146

147147
flush() {
148-
return submitterManager.execute(!isConsentGranted(settings)).then(() => {});
148+
return submitterManager.execute(!isConsentGranted(settings));
149149
},
150150

151151
// [Only used for client-side]

0 commit comments

Comments
 (0)