Update submitterManager.execute return type to Promise<void>

Author: EmilianoSanchez

src/readiness/readinessManager.ts

@@ -162,7 +162,7 @@ export function readinessManagerFactory(
     isTimedout() { return hasTimedout && !isReady; },
     hasTimedout() { return hasTimedout; },
     isDestroyed() { return isDestroyed; },
-    isOperational() { return isReadyFromCache && !isDestroyed; },
+    isOperational() { return (isReady || isReadyFromCache) && !isDestroyed; },
     lastUpdate() { return lastUpdate; }
   };
 

src/sync/__tests__/syncTask.mock.ts

@@ -1,6 +1,6 @@
 export function syncTaskFactory() {
   return {
-    execute: jest.fn(() => Promise.resolve(true)),
+    execute: jest.fn(),
     isExecuting: jest.fn(),
     start: jest.fn(),
     stop: jest.fn(),

src/sync/submitters/submitterManager.ts

@@ -38,7 +38,7 @@ export function submitterManagerFactory(params: ISdkFactoryContextSync): ISubmit
     execute(onlyTelemetry?: boolean) {
       const promises = onlyTelemetry ? [] : submitters.map(submitter => submitter.execute());
       if (telemetrySubmitter) promises.push(telemetrySubmitter.execute());
-      return Promise.all(promises);
+      return Promise.all(promises).then(() => { });
     },
 
     isExecuting() {

src/sync/submitters/types.ts

@@ -237,5 +237,5 @@ export type TelemetryConfigStatsPayload = TelemetryConfigStats & {
 export interface ISubmitterManager extends ISyncTask {
   start(onlyTelemetry?: boolean): void,
   stop(allExceptTelemetry?: boolean): void,
-  execute(onlyTelemetry?: boolean): Promise<any>
+  execute(onlyTelemetry?: boolean): Promise<void>
 }

src/sync/syncManagerOnline.ts

@@ -145,7 +145,7 @@ export function syncManagerOnlineFactory(
       },
 
       flush() {
-        return submitterManager.execute(!isConsentGranted(settings)).then(() => {});
+        return submitterManager.execute(!isConsentGranted(settings));
       },
 
       // [Only used for client-side]