Simplify set utils and add CHANGELOG entry

Author: EmilianoSanchez

.eslintrc

@@ -80,7 +80,7 @@
             "message": "Don't declare const enum, because it is not supported by Babel used for building RN SDK"
           }
         ],
-        "compat/compat": ["error", "defaults, node 14"],
+        "compat/compat": ["error", "defaults, node >=14"],
         "no-throw-literal": "error",
         "import/no-default-export": "error",
         "import/no-self-import": "error"

CHANGES.txt

@@ -3,10 +3,11 @@
  - Added `factory.destroy()` method, which invokes the `destroy` method on all SDK clients created by the factory.
  - Bugfixing - Fixed an issue with the server-side polling manager that caused dangling timers when the SDK was destroyed before it was ready.
  - BREAKING CHANGES:
-   - Removed the deprecated `GOOGLE_ANALYTICS_TO_SPLIT` and `SPLIT_TO_GOOGLE_ANALYTICS` integrations.
    - Updated default flag spec version to 1.2.
    - Removed `/mySegments` endpoint from SplitAPI module, as it is replaced by `/memberships` endpoint.
    - Removed support for MY_SEGMENTS_UPDATE and MY_SEGMENTS_UPDATE_V2 notification types, as they are replaced by MEMBERSHIPS_MS_UPDATE and MEMBERSHIPS_LS_UPDATE notification types.
+   - Removed the deprecated `GOOGLE_ANALYTICS_TO_SPLIT` and `SPLIT_TO_GOOGLE_ANALYTICS` integrations.
+   - Removed internal ponyfills for `Map`, `Set` and `Array.from` global objects, dropping support for IE and other outdated browsers. The SDK now requires the runtime environment to support these features natively or to provide a polyfill.
 
 1.17.0 (September 6, 2024)
  - Added `sync.requestOptions.getHeaderOverrides` configuration option to enhance SDK HTTP request Headers for Authorization Frameworks.

src/utils/lang/__tests__/sets.spec.ts

@@ -1,14 +1,26 @@
-import { returnSetsUnion } from '../sets';
+import { returnSetsUnion, returnDifference } from '../sets';
 
 test('returnSetsUnion', () => {
-  const set = new Set(['1', '2', '3']);
-  const set2 = new Set(['4', '5', '6']);
+  const set = new Set(['1', '2', '3', '4']);
+  const set2 = new Set(['4', '5', '6', '1']);
   expect(returnSetsUnion(set, set2)).toEqual(new Set(['1', '2', '3', '4', '5', '6']));
-  expect(set).toEqual(new Set(['1', '2', '3']));
-  expect(set2).toEqual(new Set(['4', '5', '6']));
+  expect(set).toEqual(new Set(['1', '2', '3', '4']));
+  expect(set2).toEqual(new Set(['4', '5', '6', '1']));
 
   const emptySet = new Set([]);
   expect(returnSetsUnion(emptySet, emptySet)).toEqual(emptySet);
   expect(returnSetsUnion(set, emptySet)).toEqual(set);
   expect(returnSetsUnion(emptySet, set2)).toEqual(set2);
 });
+
+test('returnDifference', () => {
+  const list = ['1', '2', '3'];
+  const list2 = ['2', '3', '4'];
+  expect(returnDifference(list, list2)).toEqual(['1']);
+  expect(list).toEqual(['1', '2', '3']);
+  expect(list2).toEqual(['2', '3', '4']);
+
+  expect(returnDifference([], [])).toEqual([]);
+  expect(returnDifference(list, [])).toEqual(list);
+  expect(returnDifference([], list2)).toEqual([]);
+});

src/utils/lang/sets.ts

@@ -1,15 +1,7 @@
 export function returnSetsUnion<T>(set: Set<T>, set2: Set<T>): Set<T> {
-  const result = new Set(Array.from(set));
-  set2.forEach(value => {
-    result.add(value);
-  });
-  return result;
+  return new Set(Array.from(set).concat(Array.from(set2)));
 }
 
 export function returnDifference<T>(list: T[] = [], list2: T[] = []): T[] {
-  const result = new Set(list);
-  list2.forEach(item => {
-    result.delete(item);
-  });
-  return Array.from(result);
+  return list.filter(item => list2.indexOf(item) === -1);
 }