Skip to content

Commit 3b6780e

Browse files
committed
Revert "Updated sync and api classes"
This reverts commit 5bda502.
1 parent 5bda502 commit 3b6780e

File tree

6 files changed

+193
-417
lines changed

6 files changed

+193
-417
lines changed

splitio/api/commons.py

Lines changed: 2 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ def record_telemetry(status_code, elapsed, metric_name, telemetry_runtime_produc
5757
class FetchOptions(object):
5858
"""Fetch Options object."""
5959

60-
def __init__(self, cache_control_headers=False, change_number=None, rbs_change_number=None, sets=None, spec=SPEC_VERSION):
60+
def __init__(self, cache_control_headers=False, change_number=None, sets=None, spec=SPEC_VERSION):
6161
"""
6262
Class constructor.
6363
@@ -72,7 +72,6 @@ def __init__(self, cache_control_headers=False, change_number=None, rbs_change_n
7272
"""
7373
self._cache_control_headers = cache_control_headers
7474
self._change_number = change_number
75-
self._rbs_change_number = rbs_change_number
7675
self._sets = sets
7776
self._spec = spec
7877

@@ -86,11 +85,6 @@ def change_number(self):
8685
"""Return change number."""
8786
return self._change_number
8887

89-
@property
90-
def rbs_change_number(self):
91-
"""Return change number."""
92-
return self._rbs_change_number
93-
9488
@property
9589
def sets(self):
9690
"""Return sets."""
@@ -109,19 +103,14 @@ def __eq__(self, other):
109103
if self._change_number != other._change_number:
110104
return False
111105

112-
if self._rbs_change_number != other._rbs_change_number:
113-
return False
114-
115106
if self._sets != other._sets:
116107
return False
117-
118108
if self._spec != other._spec:
119109
return False
120-
121110
return True
122111

123112

124-
def build_fetch(change_number, fetch_options, metadata, rbs_change_number=None):
113+
def build_fetch(change_number, fetch_options, metadata):
125114
"""
126115
Build fetch with new flags if that is the case.
127116
@@ -134,16 +123,11 @@ def build_fetch(change_number, fetch_options, metadata, rbs_change_number=None):
134123
:param metadata: Metadata Headers.
135124
:type metadata: dict
136125
137-
:param rbs_change_number: Last known timestamp of a rule based segment modification.
138-
:type rbs_change_number: int
139-
140126
:return: Objects for fetch
141127
:rtype: dict, dict
142128
"""
143129
query = {'s': fetch_options.spec} if fetch_options.spec is not None else {}
144130
query['since'] = change_number
145-
if rbs_change_number is not None:
146-
query['rbSince'] = rbs_change_number
147131
extra_headers = metadata
148132
if fetch_options is None:
149133
return query, extra_headers

splitio/api/splits.py

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -31,24 +31,21 @@ def __init__(self, client, sdk_key, sdk_metadata, telemetry_runtime_producer):
3131
self._telemetry_runtime_producer = telemetry_runtime_producer
3232
self._client.set_telemetry_data(HTTPExceptionsAndLatencies.SPLIT, self._telemetry_runtime_producer)
3333

34-
def fetch_splits(self, change_number, rbs_change_number, fetch_options):
34+
def fetch_splits(self, change_number, fetch_options):
3535
"""
3636
Fetch feature flags from backend.
3737
3838
:param change_number: Last known timestamp of a split modification.
3939
:type change_number: int
4040
41-
:param rbs_change_number: Last known timestamp of a rule based segment modification.
42-
:type rbs_change_number: int
43-
4441
:param fetch_options: Fetch options for getting feature flag definitions.
4542
:type fetch_options: splitio.api.commons.FetchOptions
4643
4744
:return: Json representation of a splitChanges response.
4845
:rtype: dict
4946
"""
5047
try:
51-
query, extra_headers = build_fetch(change_number, fetch_options, self._metadata, rbs_change_number)
48+
query, extra_headers = build_fetch(change_number, fetch_options, self._metadata)
5249
response = self._client.get(
5350
'sdk',
5451
'splitChanges',
@@ -89,15 +86,12 @@ def __init__(self, client, sdk_key, sdk_metadata, telemetry_runtime_producer):
8986
self._telemetry_runtime_producer = telemetry_runtime_producer
9087
self._client.set_telemetry_data(HTTPExceptionsAndLatencies.SPLIT, self._telemetry_runtime_producer)
9188

92-
async def fetch_splits(self, change_number, rbs_change_number, fetch_options):
89+
async def fetch_splits(self, change_number, fetch_options):
9390
"""
9491
Fetch feature flags from backend.
9592
9693
:param change_number: Last known timestamp of a split modification.
9794
:type change_number: int
98-
99-
:param rbs_change_number: Last known timestamp of a rule based segment modification.
100-
:type rbs_change_number: int
10195
10296
:param fetch_options: Fetch options for getting feature flag definitions.
10397
:type fetch_options: splitio.api.commons.FetchOptions
@@ -106,7 +100,7 @@ async def fetch_splits(self, change_number, rbs_change_number, fetch_options):
106100
:rtype: dict
107101
"""
108102
try:
109-
query, extra_headers = build_fetch(change_number, fetch_options, self._metadata, rbs_change_number)
103+
query, extra_headers = build_fetch(change_number, fetch_options, self._metadata)
110104
response = await self._client.get(
111105
'sdk',
112106
'splitChanges',

0 commit comments

Comments
 (0)