updated metadata to recent spec

Author: chillaq

splitio/events/events_metadata.py

@@ -1,46 +1,35 @@
 """Events Metadata."""
-from splitio.models.events import SdkEvent, SdkInternalEvent 
+from enum import Enum
+
+class SdkEventType(Enum):
+    """Public event types"""
+    
+    FLAG_UPDATE = 'FLAG_UPDATE'
+    SEGMENT_UPDATE = 'SEGMENT_UPDATE'
 
 class EventsMetadata(object):
     """Events Metadata class."""
 
-    def __init__(self, metadata):
+    def __init__(self, type, names):
         """
         Construct Events Metadata instance.
         """
-        self._metadata = self._sanitize(metadata)
+        self._type = type
+        self._names = self._sanitize(names)
 
-    def get_data(self):
-        """Return metadata dict"""
-        return self._metadata
+    def get_type(self):
+        """Return type"""
+        return self._type
 
-    def get_keys(self):
-        """Return metadata dict keys"""
-        return self._metadata.keys()
-
-    def get_values(self):
-        """Return metadata dict values"""
-        return self._metadata.values()
-    
-    def contain_key(self, key):
-        """Return True if key is contained in metadata"""
-        return key in self._metadata.keys()
+    def get_names(self):
+        """Return names"""
+        return self._names
 
-    def _sanitize(self, data):
-        """Return sanitized metadata dict with values either int, bool, str or list """
-        santized_data = {}
-        for item_name, item_value in data.items():
-            if self._value_is_valid(item_value): 
-                santized_data[item_name] = item_value
+    def _sanitize(self, names):
+        """Return sanitized names list with values str"""
+        santized_data = set()
+        for name in names:
+            if isinstance(name, str): 
+                santized_data.add(name)
 
         return santized_data
-
-    def _value_is_valid(self, value):
-        """Return bool if values is int, bool, str or list[str] """
-        if (value is not None) and (isinstance(value, int) or isinstance(value, bool) or isinstance(value, str)):
-            return True
-        
-        if isinstance(value, set):
-            return any([isinstance(item, str) for item in value])
-
-        return False

tests/events/test_events_metadata.py

@@ -2,27 +2,20 @@
 import pytest
 
 from splitio.events.events_metadata import EventsMetadata
-from splitio.models.events import SdkEvent, SdkInternalEvent
+from splitio.events.events_metadata import SdkEventType
 
 class EventsMetadataTests(object):
     """Tests for EventsMetadata."""
 
     def test_build_instance(self):
-        data = { "updatedFlags": { "feature1" }, "sdkTimeout": 10 , "boolValue": True, "strValue": "value" }
-        metadata = EventsMetadata(data)
-
-        assert len(metadata.get_keys()) == 4
-        assert metadata.get_data()["updatedFlags"].pop() == "feature1"
-        assert len(metadata.get_data()["updatedFlags"]) == 0
-        assert metadata.get_data()["sdkTimeout"] == 10
-        assert metadata.get_data()["boolValue"] == True
-        assert metadata.get_data()["strValue"] == "value"
-        assert metadata.contain_key("updatedFlags")
-        assert not metadata.contain_key("not_exist")
-        assert len(metadata.get_values()) == 4
+        metadata = EventsMetadata(SdkEventType.FLAG_UPDATE, { "feature1" })
+        assert len(metadata.get_names()) == 1
+        assert metadata.get_names().pop() == "feature1"
+        assert len(metadata.get_names()) == 0
+        assert metadata.get_type() == SdkEventType.FLAG_UPDATE
 
     def test_sanitize_none_input(self):
-        data = { "updatedFlags": { "feature1" }, "sdkTimeout": None, "strValue": [1, 2, 3] }
-        metadata = EventsMetadata(data)
-        assert len(metadata.get_keys()) == 1
-        assert metadata.get_data()["updatedFlags"].pop() == "feature1"
+        metadata = EventsMetadata(SdkEventType.FLAG_UPDATE, { "feature1", None, 123, False })
+        assert len(metadata.get_names()) == 1
+        assert metadata.get_names().pop() == "feature1"
+        assert len(metadata.get_names()) == 0