Skip to content

Commit 7b6e192

Browse files
authored
Merge branch 'development' into feature/impressions-properties
2 parents d8584ec + 28bdff9 commit 7b6e192

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

lib/splitclient-rb/cache/repositories/rule_based_segments_repository.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,8 @@ def clear
8585

8686
def contains?(segment_names)
8787
return false if rule_based_segment_names.empty?
88-
return set(segment_names).subset?(rule_based_segment_names)
88+
89+
return segment_names.to_set.subset?(rule_based_segment_names.to_set)
8990
end
9091

9192
private

spec/cache/repositories/rule_based_segments_repository_spec.rb

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,11 @@
4040
)
4141
end
4242

43+
it 'contains' do
44+
expect(repository.contains?(['foo', 'bar'].to_set)).to eq(true)
45+
expect(repository.contains?(['foo', 'oof'].to_set)).to eq(false)
46+
end
47+
4348
it 'remove undefined matcher with template condition' do
4449
rule_based_segment = { name: 'corge', trafficTypeName: 'tt_name_5', conditions: [
4550
{

splitclient-rb.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ Gem::Specification.new do |spec|
5555
spec.add_runtime_dependency 'faraday', '>= 1.1', '< 3.0'
5656
spec.add_runtime_dependency 'faraday-net_http_persistent', '>= 1.0', '< 3.0'
5757
spec.add_runtime_dependency 'json', '>= 1.8', '< 3.0'
58-
spec.add_runtime_dependency 'jwt', '>= 1.0.0', '< 3.0'
58+
spec.add_runtime_dependency 'jwt', '>= 3.1'
5959
spec.add_runtime_dependency 'lru_redux', '~> 1.1'
6060
spec.add_runtime_dependency 'net-http-persistent', '>= 2.9', '< 5.0'
6161
spec.add_runtime_dependency 'redis', '>= 4.0.0', '< 6.0'

0 commit comments

Comments
 (0)