Do not storage alternative in cookie if experiment has a winner (#539)

Author: sadhu89

lib/split/trial.rb

@@ -80,7 +80,7 @@ def choose!(context = nil)
         end
       end
 
-      @user[@experiment.key] = alternative.name if should_store_alternative?
+      @user[@experiment.key] = alternative.name if !@experiment.has_winner? && should_store_alternative?
       @alternative_choosen = true
       run_callback context, Split.configuration.on_trial unless @options[:disabled] || Split.configuration.disabled?
       alternative

spec/trial_spec.rb

@@ -283,5 +283,17 @@ def expect_alternative(trial, alternative_name)
         trial.choose!
       end
     end
+
+    context 'when experiment has winner' do
+      let(:trial) do
+        experiment.winner = 'cart'
+        Split::Trial.new(:user => user, :experiment => experiment)
+      end
+
+      it 'does not store' do
+        expect(user).to_not receive("[]=")
+        trial.choose!
+      end
+    end
   end
 end