Skip to content

Commit 17bb00b

Browse files
mcmiremcmire
committed
Clean up Rubocop configuration
* Remove outdated or unnecessary overrides * Update all files to support new style
1 parent 8480fd4 commit 17bb00b

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

54 files changed

+498
-557
lines changed

‎.rubocop.yml

Lines changed: 43 additions & 164 deletions
Original file line numberDiff line numberDiff line change
@@ -2,255 +2,134 @@
22
AllCops:
33
Exclude:
44
- db/schema.rb
5-
TargetRubyVersion: 2.4
5+
TargetRubyVersion: 2.5
6+
Layout/AlignParameters:
7+
EnforcedStyle: with_fixed_indentation
8+
Layout/ClassStructure:
9+
Enabled: true
610
Layout/DotPosition:
711
EnforcedStyle: trailing
8-
Layout/ExtraSpacing:
9-
Enabled: true
1012
Layout/InitialIndentation:
1113
Enabled: false
1214
Layout/IndentArray:
1315
EnforcedStyle: "consistent"
1416
Layout/IndentHash:
1517
EnforcedStyle: "consistent"
18+
Layout/IndentHeredoc:
19+
Enabled: false
1620
Layout/MultilineOperationIndentation:
17-
Enabled: true
1821
EnforcedStyle: indented
1922
Layout/MultilineMethodCallIndentation:
20-
Enabled: true
2123
EnforcedStyle: indented
22-
Lint/AmbiguousOperator:
24+
Layout/SpaceInLambdaLiteral:
2325
Enabled: false
24-
Lint/AmbiguousRegexpLiteral:
26+
Layout/SpaceInsideStringInterpolation:
2527
Enabled: false
2628
Lint/AssignmentInCondition:
2729
Enabled: false
28-
Lint/CircularArgumentReference:
29-
Enabled: false
30-
Lint/ConditionPosition:
31-
Enabled: false
32-
Lint/DeprecatedClassMethods:
33-
Enabled: false
34-
Lint/DuplicatedKey:
35-
Enabled: false
36-
Lint/EachWithObjectArgument:
37-
Enabled: false
38-
Lint/ElseLayout:
39-
Enabled: false
40-
Lint/FormatParameterMismatch:
41-
Enabled: false
4230
Lint/HandleExceptions:
4331
Enabled: false
44-
Lint/LiteralInInterpolation:
45-
Enabled: false
46-
Lint/Loop:
47-
Enabled: false
48-
Lint/NestedMethodDefinition:
49-
Enabled: false
50-
Lint/NonLocalExitFromIterator:
51-
Enabled: false
52-
Lint/ParenthesesAsGroupedExpression:
53-
Enabled: false
5432
Lint/RequireParentheses:
5533
Enabled: false
56-
Lint/UnderscorePrefixedVariableName:
57-
Enabled: false
58-
Lint/UnneededDisable:
59-
Enabled: false
60-
Lint/Void:
61-
Enabled: false
6234
Metrics/AbcSize:
63-
Enabled: false
64-
Metrics/BlockNesting:
65-
Enabled: false
35+
Max: 32
36+
Metrics/BlockLength:
37+
ExcludedMethods:
38+
- describe
39+
- context
40+
- it
41+
- colored
6642
Metrics/ClassLength:
6743
Enabled: false
68-
Metrics/CyclomaticComplexity:
69-
Enabled: false
7044
Metrics/LineLength:
71-
Max: 120
45+
Max: 80
46+
IgnoredPatterns:
47+
- "^\\s*describe"
48+
- "^\\s*context"
49+
- "^\\s*it"
7250
Metrics/MethodLength:
7351
Enabled: false
7452
Metrics/ModuleLength:
7553
Enabled: false
7654
Metrics/ParameterLists:
77-
Enabled: false
78-
Naming/AccessorMethodName:
79-
Enabled: false
80-
Naming/AsciiIdentifiers:
81-
Enabled: false
82-
Naming/BinaryOperatorParameterName:
83-
Enabled: false
84-
Naming/FileName:
85-
Enabled: false
55+
CountKeywordArgs: false
56+
Naming/MemoizedInstanceVariableName:
57+
EnforcedStyleForLeadingUnderscores: required
8658
Naming/PredicateName:
8759
NamePrefixBlacklist:
8860
- is_
8961
Exclude:
9062
- spec/**/*
91-
Performance/CaseWhenSplat:
92-
Enabled: false
93-
Performance/Count:
94-
Enabled: false
95-
Performance/Detect:
96-
Enabled: false
97-
Performance/FlatMap:
98-
Enabled: false
99-
Performance/ReverseEach:
100-
Enabled: false
101-
Performance/Sample:
102-
Enabled: false
103-
Performance/Size:
104-
Enabled: false
105-
Performance/StringReplacement:
106-
Enabled: false
107-
Rails/ActionFilter:
108-
Enabled: false
109-
Rails/Date:
110-
Enabled: false
111-
Rails/Delegate:
112-
Enabled: false
113-
Rails/FindBy:
114-
Enabled: false
115-
Rails/FindEach:
116-
Enabled: false
117-
Rails/HasAndBelongsToMany:
118-
Enabled: false
119-
Rails/Output:
120-
Enabled: false
121-
Rails/ReadWriteAttribute:
122-
Enabled: false
123-
Rails/ScopeArgs:
63+
Naming/UncommunicativeMethodParamName:
12464
Enabled: false
65+
Rails:
66+
Enabled: true
67+
Rails/SaveBang:
68+
Enabled: true
12569
Rails/TimeZone:
126-
Enabled: false
127-
Rails/Validation:
128-
Enabled: false
70+
EnforcedStyle: strict
12971
Style/Alias:
13072
Enabled: false
131-
Style/ArrayJoin:
132-
Enabled: false
133-
Style/AsciiComments:
134-
Enabled: false
135-
Style/Attr:
136-
Enabled: false
13773
Style/BracesAroundHashParameters:
138-
Enabled: false
139-
Style/CaseEquality:
140-
Enabled: false
141-
Style/CharacterLiteral:
142-
Enabled: false
143-
Style/ClassAndModuleChildren:
144-
Enabled: true
145-
EnforcedStyle: nested
146-
Style/ClassVars:
147-
Enabled: false
74+
EnforcedStyle: context_dependent
14875
Style/CollectionMethods:
14976
Enabled: true
150-
PreferredMethods:
151-
find: detect
152-
inject: reduce
153-
collect: map
154-
find_all: select
155-
Style/ColonMethodCall:
156-
Enabled: false
157-
Style/CommentAnnotation:
158-
Enabled: false
15977
Style/Documentation:
16078
Enabled: false
161-
Style/DoubleNegation:
162-
Enabled: false
16379
Style/EachWithObject:
16480
Enabled: false
165-
Style/EmptyLiteral:
166-
Enabled: false
16781
Style/EmptyMethod:
16882
EnforcedStyle: expanded
169-
Style/Encoding:
170-
Enabled: false
171-
Style/EvenOdd:
172-
Enabled: false
173-
Style/FrozenStringLiteralComment:
174-
Enabled: false
175-
Style/FlipFlop:
176-
Enabled: false
17783
Style/FormatString:
178-
Enabled: false
179-
Style/GlobalVars:
84+
EnforcedStyle: percent
85+
Style/FrozenStringLiteralComment:
18086
Enabled: false
18187
Style/GuardClause:
18288
Enabled: false
18389
Style/IfUnlessModifier:
18490
Enabled: false
185-
Style/IfWithSemicolon:
186-
Enabled: false
187-
Style/InlineComment:
188-
Enabled: false
18991
Style/Lambda:
19092
Enabled: false
191-
Style/LambdaCall:
192-
Enabled: false
19393
Style/LineEndConcatenation:
19494
Enabled: false
195-
Style/ModuleFunction:
196-
Enabled: false
95+
Style/MethodCalledOnDoEndBlock:
96+
Enabled: true
19797
Style/MultilineBlockChain:
19898
Enabled: false
19999
Style/NegatedIf:
200100
Enabled: false
201101
Style/NegatedWhile:
202102
Enabled: false
203-
Style/Next:
204-
Enabled: false
205-
Style/NilComparison:
206-
Enabled: false
207-
Style/Not:
208-
Enabled: false
209-
Style/NumericLiterals:
210-
Enabled: false
211103
Style/OneLineConditional:
212104
Enabled: false
213105
Style/PercentLiteralDelimiters:
214106
Enabled: false
215-
Style/PerlBackrefs:
216-
Enabled: false
217107
Style/PreferredHashMethods:
218108
Enabled: false
219-
Style/Proc:
220-
Enabled: false
221109
Style/RaiseArgs:
222110
Enabled: false
223-
Style/RegexpLiteral:
224-
Enabled: false
225111
Style/SafeNavigation:
226112
Enabled: false
227-
Style/SelfAssignment:
228-
Enabled: false
229-
Style/SingleLineBlockParams:
230-
Enabled: false
231-
Style/SingleLineMethods:
232-
Enabled: false
113+
Style/Send:
114+
Enabled: true
233115
Style/SignalException:
234116
Enabled: false
235117
Style/SpecialGlobalVars:
236118
Enabled: false
237119
Style/StringLiterals:
238120
EnforcedStyle: double_quotes
121+
Style/StringLiteralsInInterpolation:
122+
EnforcedStyle: double_quotes
123+
Style/StringMethods:
239124
Enabled: true
240125
Style/SymbolArray:
241126
Enabled: false
242127
Style/TrailingCommaInArguments:
243128
EnforcedStyleForMultiline: comma
244-
Enabled: true
245-
Style/TrailingCommaInLiteral:
129+
Style/TrailingCommaInArrayLiteral:
130+
EnforcedStyleForMultiline: comma
131+
Style/TrailingCommaInHashLiteral:
246132
EnforcedStyleForMultiline: comma
247-
Enabled: true
248-
Style/TrivialAccessors:
249-
Enabled: false
250-
Style/VariableInterpolation:
251-
Enabled: false
252-
Style/WhenThen:
253-
Enabled: false
254133
Style/WhileUntilModifier:
255134
Enabled: false
256135
Style/WordArray:

0 commit comments

Comments
 (0)