Name 'fuzzy' objects more after what RSpec calls them

Author: mcmire

lib/super_diff/rspec.rb

@@ -25,30 +25,30 @@ def self.configuration
       @_configuration ||= Configuration.new
     end
 
-    def self.partial_hash?(value)
-      partial_placeholder?(value) &&
+    def self.a_hash_including_something?(value)
+      fuzzy_object?(value) &&
         value.respond_to?(:expecteds) &&
         value.expecteds.one? &&
         value.expecteds.first.is_a?(::Hash)
     end
 
-    def self.partial_array?(value)
-      partial_placeholder?(value) &&
+    def self.a_collection_including_something?(value)
+      fuzzy_object?(value) &&
         value.respond_to?(:expecteds) &&
         !(value.expecteds.one? && value.expecteds.first.is_a?(::Hash))
     end
 
-    def self.partial_object?(value)
-      partial_placeholder?(value) &&
+    def self.an_object_having_some_attributes?(value)
+      fuzzy_object?(value) &&
         value.base_matcher.is_a?(::RSpec::Matchers::BuiltIn::HaveAttributes)
     end
 
-    def self.collection_containing_exactly?(value)
-      partial_placeholder?(value) &&
+    def self.a_collection_containing_exactly_something?(value)
+      fuzzy_object?(value) &&
         value.base_matcher.is_a?(::RSpec::Matchers::BuiltIn::ContainExactly)
     end
 
-    def self.partial_placeholder?(value)
+    def self.fuzzy_object?(value)
       value.is_a?(::RSpec::Matchers::AliasedMatcher)
     end
   end

lib/super_diff/rspec/differ.rb

@@ -14,16 +14,16 @@ def diff
             extra_classes: [
               *RSpec.configuration.extra_differ_classes,
               Differs::CollectionContainingExactly,
-              Differs::PartialArray,
-              Differs::PartialHash,
-              Differs::PartialObject,
+              Differs::CollectionIncluding,
+              Differs::HashIncluding,
+              Differs::ObjectHavingAttributes,
             ],
             extra_operational_sequencer_classes: [
               *RSpec.configuration.extra_operational_sequencer_classes,
               OperationalSequencers::CollectionContainingExactly,
-              OperationalSequencers::PartialArray,
-              OperationalSequencers::PartialHash,
-              OperationalSequencers::PartialObject,
+              OperationalSequencers::CollectionIncluding,
+              OperationalSequencers::HashIncluding,
+              OperationalSequencers::ObjectHavingAttributes,
             ],
             extra_diff_formatter_classes: RSpec.configuration.extra_diff_formatter_classes,
           )

lib/super_diff/rspec/differs.rb

@@ -5,9 +5,15 @@ module Differs
         :CollectionContainingExactly,
         "super_diff/rspec/differs/collection_containing_exactly",
       )
-      autoload :PartialArray, "super_diff/rspec/differs/partial_array"
-      autoload :PartialHash, "super_diff/rspec/differs/partial_hash"
-      autoload :PartialObject, "super_diff/rspec/differs/partial_object"
+      autoload(
+        :CollectionIncluding,
+        "super_diff/rspec/differs/collection_including",
+      )
+      autoload :HashIncluding, "super_diff/rspec/differs/hash_including"
+      autoload(
+        :ObjectHavingAttributes,
+        "super_diff/rspec/differs/object_having_attributes",
+      )
     end
   end
 end

lib/super_diff/rspec/differs/collection_containing_exactly.rb

@@ -3,7 +3,7 @@ module RSpec
     module Differs
       class CollectionContainingExactly < SuperDiff::Differs::Array
         def self.applies_to?(expected, actual)
-          SuperDiff::RSpec.collection_containing_exactly?(expected) &&
+          SuperDiff::RSpec.a_collection_containing_exactly_something?(expected) &&
             actual.is_a?(::Array)
         end
 

lib/super_diff/rspec/differs/partial_hash.rb renamed to lib/super_diff/rspec/differs/collection_including.rb

@@ -1,15 +1,16 @@
 module SuperDiff
   module RSpec
     module Differs
-      class PartialHash < SuperDiff::Differs::Hash
+      class CollectionIncluding < SuperDiff::Differs::Array
         def self.applies_to?(expected, actual)
-          SuperDiff::RSpec.partial_hash?(expected) && actual.is_a?(::Hash)
+          SuperDiff::RSpec.a_collection_including_something?(expected) &&
+            actual.is_a?(::Array)
         end
 
         private
 
         def operations
-          OperationalSequencers::PartialHash.call(
+          OperationalSequencers::CollectionIncluding.call(
             expected: expected,
             actual: actual,
             extra_operational_sequencer_classes: extra_operational_sequencer_classes,

lib/super_diff/rspec/differs/partial_array.rb renamed to lib/super_diff/rspec/differs/hash_including.rb

@@ -1,15 +1,16 @@
 module SuperDiff
   module RSpec
     module Differs
-      class PartialArray < SuperDiff::Differs::Array
+      class HashIncluding < SuperDiff::Differs::Hash
         def self.applies_to?(expected, actual)
-          SuperDiff::RSpec.partial_array?(expected) && actual.is_a?(::Array)
+          SuperDiff::RSpec.a_hash_including_something?(expected) &&
+            actual.is_a?(::Hash)
         end
 
         private
 
         def operations
-          OperationalSequencers::PartialArray.call(
+          OperationalSequencers::HashIncluding.call(
             expected: expected,
             actual: actual,
             extra_operational_sequencer_classes: extra_operational_sequencer_classes,

lib/super_diff/rspec/differs/partial_object.rb renamed to lib/super_diff/rspec/differs/object_having_attributes.rb

@@ -1,15 +1,15 @@
 module SuperDiff
   module RSpec
     module Differs
-      class PartialObject < SuperDiff::Differs::DefaultObject
+      class ObjectHavingAttributes < SuperDiff::Differs::DefaultObject
         def self.applies_to?(expected, _actual)
-          SuperDiff::RSpec.partial_object?(expected)
+          SuperDiff::RSpec.an_object_having_some_attributes?(expected)
         end
 
         private
 
         def operations
-          OperationalSequencers::PartialObject.call(
+          OperationalSequencers::ObjectHavingAttributes.call(
             expected: expected,
             actual: actual,
             extra_operational_sequencer_classes: extra_operational_sequencer_classes,

lib/super_diff/rspec/monkey_patches.rb

@@ -695,6 +695,11 @@ class RespondTo
         prepend SuperDiff::RSpec::AugmentedMatcher
 
         prepend(Module.new do
+          def initialize(*)
+            super
+            @failing_method_names = nil
+          end
+
           def matcher_text_builder_class
             SuperDiff::RSpec::MatcherTextBuilders::RespondTo
           end

lib/super_diff/rspec/object_inspection/inspectors.rb

@@ -7,16 +7,16 @@ module Inspectors
           "super_diff/rspec/object_inspection/inspectors/collection_containing_exactly",
         )
         autoload(
-          :PartialArray,
-          "super_diff/rspec/object_inspection/inspectors/partial_array",
+          :CollectionIncluding,
+          "super_diff/rspec/object_inspection/inspectors/collection_including",
         )
         autoload(
-          :PartialHash,
-          "super_diff/rspec/object_inspection/inspectors/partial_hash",
+          :HashIncluding,
+          "super_diff/rspec/object_inspection/inspectors/hash_including",
         )
         autoload(
-          :PartialObject,
-          "super_diff/rspec/object_inspection/inspectors/partial_object",
+          :ObjectHavingAttributes,
+          "super_diff/rspec/object_inspection/inspectors/object_having_attributes",
         )
       end
     end

lib/super_diff/rspec/object_inspection/inspectors/partial_array.rb renamed to lib/super_diff/rspec/object_inspection/inspectors/collection_including.rb

@@ -2,9 +2,9 @@ module SuperDiff
   module RSpec
     module ObjectInspection
       module Inspectors
-        PartialArray = SuperDiff::ObjectInspection::InspectionTree.new do
+        CollectionIncluding = SuperDiff::ObjectInspection::InspectionTree.new do
           def self.applies_to?(object)
-            SuperDiff::RSpec.partial_array?(object)
+            SuperDiff::RSpec.a_collection_including?(object)
           end
 
           add_text "#<a collection including ("