Skip to content

Commit a0aef2e

Browse files
committed
Move ObjectInspection.inspect
It isn't good to name a method `inspect`, even if it's on the class level. This prevents the class from being inspected, which can easily happen automatically in an IRB console.
1 parent 27b9b33 commit a0aef2e

File tree

12 files changed

+160
-100
lines changed

12 files changed

+160
-100
lines changed

lib/super_diff.rb

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,14 @@ def self.configuration
3030
@_configuration ||= Configuration.new
3131
end
3232

33+
def self.inspect_object(object, as_single_line:, indent_level: 0)
34+
ObjectInspection::Inspectors::Main.call(
35+
object,
36+
as_single_line: as_single_line,
37+
indent_level: indent_level,
38+
)
39+
end
40+
3341
def self.time_like?(value)
3442
# Check for ActiveSupport's #acts_like_time? for their time-like objects
3543
# (like ActiveSupport::TimeWithZone).

lib/super_diff/diff_formatters/collection.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ def build_chunk_for(operation, prefix:, icon:)
9494
end
9595

9696
def build_chunk_by_inspecting(value, prefix:, icon:)
97-
inspection = ObjectInspection.inspect(
97+
inspection = SuperDiff.inspect_object(
9898
value,
9999
as_single_line: false,
100100
)

lib/super_diff/equality_matchers/array.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,14 @@ def fail
1313
Helpers.style(
1414
:expected,
1515
"Expected: " +
16-
ObjectInspection.inspect(expected, as_single_line: true),
16+
SuperDiff.inspect_object(expected, as_single_line: true),
1717
)
1818
}
1919
#{
2020
Helpers.style(
2121
:actual,
2222
" Actual: " +
23-
ObjectInspection.inspect(actual, as_single_line: true),
23+
SuperDiff.inspect_object(actual, as_single_line: true),
2424
)
2525
}
2626

lib/super_diff/equality_matchers/default.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,15 @@ def expected_line
2121
Helpers.style(
2222
:expected,
2323
"Expected: " +
24-
ObjectInspection.inspect(expected, as_single_line: true),
24+
SuperDiff.inspect_object(expected, as_single_line: true),
2525
)
2626
end
2727

2828
def actual_line
2929
Helpers.style(
3030
:actual,
3131
" Actual: " +
32-
ObjectInspection.inspect(actual, as_single_line: true),
32+
SuperDiff.inspect_object(actual, as_single_line: true),
3333
)
3434
end
3535

lib/super_diff/equality_matchers/hash.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,14 @@ def fail
1313
Helpers.style(
1414
:expected,
1515
"Expected: " +
16-
ObjectInspection.inspect(expected, as_single_line: true),
16+
SuperDiff.inspect_object(expected, as_single_line: true),
1717
)
1818
}
1919
#{
2020
Helpers.style(
2121
:actual,
2222
" Actual: " +
23-
ObjectInspection.inspect(actual, as_single_line: true),
23+
SuperDiff.inspect_object(actual, as_single_line: true),
2424
)
2525
}
2626

lib/super_diff/equality_matchers/multiline_string.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,14 @@ def fail
1414
Helpers.style(
1515
:expected,
1616
"Expected: " +
17-
ObjectInspection.inspect(expected, as_single_line: true),
17+
SuperDiff.inspect_object(expected, as_single_line: true),
1818
)
1919
}
2020
#{
2121
Helpers.style(
2222
:actual,
2323
" Actual: " +
24-
ObjectInspection.inspect(actual, as_single_line: true),
24+
SuperDiff.inspect_object(actual, as_single_line: true),
2525
)
2626
}
2727

lib/super_diff/equality_matchers/primitive.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,14 @@ def fail
1717
Helpers.style(
1818
:expected,
1919
"Expected: " +
20-
ObjectInspection.inspect(expected, as_single_line: true),
20+
SuperDiff.inspect_object(expected, as_single_line: true),
2121
)
2222
}
2323
#{
2424
Helpers.style(
2525
:actual,
2626
" Actual: " +
27-
ObjectInspection.inspect(actual, as_single_line: true),
27+
SuperDiff.inspect_object(actual, as_single_line: true),
2828
)
2929
}
3030
OUTPUT

lib/super_diff/equality_matchers/singleline_string.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,14 @@ def fail
1313
Helpers.style(
1414
:expected,
1515
"Expected: " +
16-
ObjectInspection.inspect(expected, as_single_line: true),
16+
SuperDiff.inspect_object(expected, as_single_line: true),
1717
)
1818
}
1919
#{
2020
Helpers.style(
2121
:actual,
2222
" Actual: " +
23-
ObjectInspection.inspect(actual, as_single_line: true),
23+
SuperDiff.inspect_object(actual, as_single_line: true),
2424
)
2525
}
2626
OUTPUT

lib/super_diff/object_inspection.rb

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,5 @@ module ObjectInspection
33
autoload :InspectionTree, "super_diff/object_inspection/inspection_tree"
44
autoload :Inspectors, "super_diff/object_inspection/inspectors"
55
autoload :Nodes, "super_diff/object_inspection/nodes"
6-
7-
def self.inspect(object, as_single_line:, indent_level: 0)
8-
Inspectors::Main.call(
9-
object,
10-
as_single_line: as_single_line,
11-
indent_level: indent_level,
12-
)
13-
end
146
end
157
end

lib/super_diff/object_inspection/nodes/inspection.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ def evaluate(object, indent_level:, as_single_line:)
1010
immediate_value
1111
end
1212

13-
SuperDiff::ObjectInspection.inspect(
13+
SuperDiff.inspect_object(
1414
value,
1515
indent_level: indent_level,
1616
as_single_line: as_single_line,

0 commit comments

Comments
 (0)