Clean up bad imports. Give more

explicit error when something fails
to be written correctly to a conf file.
Otherwise, it is hard to find out which
specific object caused the failure.

Author: pyth0n1c

contentctl/output/api_json_output.py

@@ -10,14 +10,9 @@
     from contentctl.objects.deployment import Deployment
 
 import os
-import json
 import pathlib
 
 from contentctl.output.json_writer import JsonWriter
-from contentctl.objects.enums import SecurityContentType
-from contentctl.objects.abstract_security_content_objects.security_content_object_abstract import (
-    SecurityContentObject_Abstract,
-)
 
 
 

contentctl/output/conf_writer.py

@@ -276,17 +276,20 @@ def writeConfFile(app_output_path:pathlib.Path, template_name : str, config: bui
         j2_env = ConfWriter.getJ2Environment()
 
         template = j2_env.get_template(template_name)
-        try:
-            for obj in objects:
-                output = template.render(objects=[obj], app=config.app)
-        except Exception as e:
-            print(e)
-            import code
-            code.interact(local=locals())
+        outputs: list[str] = []
+        for obj in objects:
+            try:
+                outputs.append(template.render(objects=[obj], app=config.app))
+            except Exception as e:
+                raise Exception(f"Failed writing the following object to file:\n"
+                                f"Name:{obj.name if not isinstance(obj, CustomApp) else obj.title}\n"
+                                f"Type {type(obj)}: \n"
+                                f"Output File: {app_output_path}\n"
+                                f"Error: {str(e)}\n")
 
         output_path.parent.mkdir(parents=True, exist_ok=True)
         with open(output_path, 'a') as f:
-            output = output.encode('utf-8', 'ignore').decode('utf-8')
+            output = ''.join(outputs).encode('utf-8', 'ignore').decode('utf-8')
             f.write(output)
         return output_path