Auto unsafe fixes

Author: ljstella

contentctl/actions/detection_testing/DetectionTestingManager.py

@@ -82,7 +82,7 @@ def sigint_handler(signum, frame):
             # Wait for all instances to be set up
             for future in concurrent.futures.as_completed(future_instances_setup):
                 try:
-                    result = future.result()
+                    future.result()
                 except Exception as e:
                     self.output_dto.terminate = True
                     print(f"Error setting up container: {str(e)}")
@@ -97,7 +97,7 @@ def sigint_handler(signum, frame):
                 # Wait for execution to finish
                 for future in concurrent.futures.as_completed(future_instances_execute):
                     try:
-                        result = future.result()
+                        future.result()
                     except Exception as e:
                         self.output_dto.terminate = True
                         print(f"Error running in container: {str(e)}")
@@ -110,14 +110,14 @@ def sigint_handler(signum, frame):
             }
             for future in concurrent.futures.as_completed(future_views_shutdowner):
                 try:
-                    result = future.result()
+                    future.result()
                 except Exception as e:
                     print(f"Error stopping view: {str(e)}")
 
             # Wait for original view-related threads to complete
             for future in concurrent.futures.as_completed(future_views):
                 try:
-                    result = future.result()
+                    future.result()
                 except Exception as e:
                     print(f"Error running container: {str(e)}")
 

contentctl/actions/detection_testing/views/DetectionTestingViewCLI.py

@@ -38,7 +38,7 @@ def setup(self):
             miniters=0,
             mininterval=0,
         )
-        fmt = self.format_pbar(
+        self.format_pbar(
             len(self.sync_obj.outputQueue), len(self.sync_obj.inputQueue)
         )
 

contentctl/helper/utils.py

@@ -141,7 +141,7 @@ def validate_git_hash(
             # Note, of course, that a hash can be in 0, 1, more branches!
             for branch_string in all_branches_containing_hash:
                 if branch_string.split(" ")[0] == "*" and (
-                    branch_string.split(" ")[-1] == branch_name or branch_name == None
+                    branch_string.split(" ")[-1] == branch_name or branch_name is None
                 ):
                     # Yes, the hash exists in the branch (or branch_name was None and it existed in at least one branch)!
                     return True
@@ -376,7 +376,7 @@ def download_file_from_http(
             )
 
         try:
-            download_start_time = default_timer()
+            default_timer()
             bytes_written = 0
             file_to_download = requests.get(file_path, stream=True)
             file_to_download.raise_for_status()

contentctl/input/yml_reader.py

@@ -42,7 +42,7 @@ def load_file(file_path: pathlib.Path, add_fields:bool=True, STRICT_YML_CHECKING
             print(exc)
             sys.exit(1)
 
-        if add_fields == False:
+        if add_fields is False:
             return yml_obj
 
 

contentctl/output/conf_output.py

@@ -53,7 +53,7 @@ def writeHeaders(self) -> set[pathlib.Path]:
 
         #The contents of app.manifest are not a conf file, but json.
         #DO NOT write a header for this file type, simply create the file
-        with open(self.config.getPackageDirectoryPath() / pathlib.Path('app.manifest'), 'w') as f:
+        with open(self.config.getPackageDirectoryPath() / pathlib.Path('app.manifest'), 'w'):
             pass