Skip to content

Commit cbaa222

Browse files
committed
Add verbose comments as to
WHY certain macros are excluded when we look for them.
1 parent 5cf7f5b commit cbaa222

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

contentctl/objects/abstract_security_content_objects/detection_abstract.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -438,7 +438,7 @@ def getDetectionMacros(cls, v:list[str], info:ValidationInfo)->list[Macro]:
438438

439439
macros_from_search = Macro.get_macros(search, director)
440440

441-
return macros_from_search + [filter_macro]
441+
return macros_from_search
442442

443443
def get_content_dependencies(self)->list[SecurityContentObject]:
444444
#Do this separately to satisfy type checker

contentctl/objects/macro.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,14 @@
99
from contentctl.objects.security_content_object import SecurityContentObject
1010

1111

12-
13-
#MACROS_TO_IGNORE = set(["_filter", "drop_dm_object_name"])
14-
MACROS_TO_IGNORE = set(["drop_dm_object_name"])
15-
#Should all of the following be included as well?
16-
MACROS_TO_IGNORE.add("get_asset" )
17-
MACROS_TO_IGNORE.add("get_risk_severity")
18-
MACROS_TO_IGNORE.add("cim_corporate_web_domain_search")
19-
MACROS_TO_IGNORE.add("prohibited_processes")
12+
#The following macros are included in commonly-installed apps.
13+
#As such, we will ignore if they are missing from our app.
14+
#Included in
15+
MACROS_TO_IGNORE = set(["drop_dm_object_name"]) # Part of CIM/Splunk_SA_CIM
16+
MACROS_TO_IGNORE.add("get_asset") #SA-IdentityManagement, part of Enterprise Security
17+
MACROS_TO_IGNORE.add("get_risk_severity") #SA-ThreatIntelligence, part of Enterprise Security
18+
MACROS_TO_IGNORE.add("cim_corporate_web_domain_search") #Part of CIM/Splunk_SA_CIM
19+
#MACROS_TO_IGNORE.add("prohibited_processes")
2020

2121

2222
class Macro(SecurityContentObject):

0 commit comments

Comments
 (0)