Skip to content

Commit e4cadcb

Browse files
resolving TODOs
1 parent e8fa869 commit e4cadcb

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

contentctl/actions/detection_testing/infrastructures/DetectionTestingInfrastructure.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1572,7 +1572,6 @@ def hec_raw_replay(
15721572
def status(self):
15731573
pass
15741574

1575-
# TODO (cmcginley): the finish function doesn't actually stop execution
15761575
def finish(self):
15771576
self.pbar.bar_format = (
15781577
f"Finished running tests on instance: [{self.get_name()}]"

contentctl/objects/content_versioning_service.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,6 @@
2222
LOG_LEVEL = logging.DEBUG
2323
LOG_PATH = "content_versioning_service.log"
2424

25-
# TODO (cmcginley): would it be better for this to only run on one instance? Or to consolidate
26-
# error reporting at least?
27-
2825

2926
class ContentVersioningService(BaseModel):
3027
"""
@@ -355,7 +352,8 @@ def validate_content_against_cms(self) -> None:
355352
count = 100
356353
offset = 0
357354
remaining_detections = {
358-
x.get_action_dot_correlationsearch_dot_label(self.global_config.app): x for x in self.detections
355+
x.get_action_dot_correlationsearch_dot_label(self.global_config.app): x
356+
for x in self.detections
359357
}
360358
matched_detections: dict[str, Detection] = {}
361359

0 commit comments

Comments
 (0)