Generate random password

Author: rcastley

workshop/aws/ec2/README.md

@@ -42,7 +42,6 @@ The following variables are available. Edit `terraform.tfvars` to reflect what y
 - `aws_region`: Which region do you want the instances in?
 - `aws_instance_count`: How many instances?
 - `slug`: Short name/tag, e.g. acme. Used to derive project and hostnames, AWS tags and terraform workspace e.g. `emea-ws`)
-- `instance_password`: Password for the EC2 instance
 
 ### Optional variables
 
@@ -68,6 +67,22 @@ terraform apply \
 -input=false
 ```
 
+Once the apply is complete, the output will contain the public IP addresses, instance names and the _(automatically generated)_ instance password.
+
+### Example output from Terraform
+
+``` text
+Apply complete! Resources: 10 added, 0 changed, 0 destroyed.
+
+Outputs:
+
+login_details = tolist([
+  "workshop-01, 10.1.1.1, mKV50oR36MgASJd3",
+  "workshop-02, 10.1.1.2, mKV50oR36MgASJd3",
+  "workshop-03, 10.1.1.3, mKV50oR36MgASJd3",
+])
+```
+
 <!--
 Or you use the provided script `up` to request instances:
 

workshop/aws/ec2/main.tf

@@ -173,14 +173,19 @@ resource "aws_route" "o11y-ws-route" {
 #   route_table_id = aws_route_table.o11y-ws-rt.id
 # }
 
+resource "random_string" "password" {
+  length           = 16
+  override_special = "_%@$#!"
+}
+
 locals {
   template_vars = {
     access_token      = var.splunk_access_token
     rum_token         = var.splunk_rum_token
     realm             = var.splunk_realm
     presetup          = var.splunk_presetup
     jdk               = var.splunk_jdk
-    instance_password = var.instance_password
+    instance_password = random_string.password.result
   }
 }
 
@@ -219,12 +224,21 @@ resource "aws_instance" "observability-instance" {
   }
 }
 
-output "instance_details" {
+#output "instance_details" {
+#  value = formatlist(
+#    "%s, %s, %s, %s",
+#    aws_instance.observability-instance[*].tags["Instance"],
+#    aws_instance.observability-instance.*.private_ip,
+#    aws_instance.observability-instance.*.public_ip,
+#    aws_instance.observability-instance[*].tags["Subnet"]
+#  )
+#}
+
+output "login_details" {
   value = formatlist(
-    "%s, %s, %s, %s",
+    "%s, %s, %s",
     aws_instance.observability-instance[*].tags["Instance"],
-    aws_instance.observability-instance.*.private_ip,
     aws_instance.observability-instance.*.public_ip,
-    aws_instance.observability-instance[*].tags["Subnet"]
+    local.template_vars.instance_password
   )
-}
+}

workshop/aws/ec2/outputs.tf

@@ -1,15 +1,15 @@
-output "ip_addresses" {
-  value = aws_instance.observability-instance.*.public_ip
-}
+#output "ip_addresses" {
+#  value = aws_instance.observability-instance.*.public_ip
+#}
 
-output "instance_names" {
-  value = aws_instance.observability-instance[*].tags["Instance"]
-}
+#output "instance_names" {
+#  value = aws_instance.observability-instance[*].tags["Instance"]
+#}
 
-output "public_subnet_ids" {
-    value = aws_subnet.o11y_ws_subnets.*.id
-}
+#output "public_subnet_ids" {
+#  value = aws_subnet.o11y_ws_subnets.*.id
+#}
 
-output "instance_password" {
-  value = var.instance_password
-}
+#output "instance_password" {
+#  value = random_string.password.result
+#}

workshop/aws/ec2/variables.tf

@@ -40,11 +40,6 @@ variable "slug" {
   description = "Short name/tag, e.g. acme. Used to derive project and hostnames, AWS tags and terraform workspace"
 }
 
-variable "instance_password" {
-  description = "Password for the EC2 instance"
-  nullable    = false
-}
-
 variable "splunk_access_token" {
   description = "Splunk Oberservability Cloud Access Token"
   default     = ""