Skip to content

Commit 86695fd

Browse files
authored
Merge pull request #245 from katzchang/fix-jenkinsreceiver-code
Fix code example on OpenTelemetry Collector workshop
2 parents 5869c8d + cc216c9 commit 86695fd

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

content/en/other/opentelemetry-collector/8-develop/5-business-logic.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ import (
4545
)
4646

4747
type scraper struct {
48-
mb *metadata.Metricsbuilder
48+
mb *metadata.MetricsBuilder
4949
client *jenkins.Jenkins
5050
}
5151

@@ -57,8 +57,8 @@ func newScraper(cfg *Config, set receiver.CreateSettings) (scraperhelper.Scraper
5757
return scraperhelper.NewScraper(
5858
metadata.Type,
5959
s.scrape,
60-
scarperhelper.WithStart(func(ctx context.Context, h component.Host) error {
61-
client, err := cfg.ToClient(h, set)
60+
scraperhelper.WithStart(func(ctx context.Context, h component.Host) error {
61+
client, err := cfg.ToClient(h, set.TelemetrySettings)
6262
if err != nil {
6363
return err
6464
}
@@ -68,11 +68,11 @@ func newScraper(cfg *Config, set receiver.CreateSettings) (scraperhelper.Scraper
6868
s.client = jenkins.NewJenkins(nil, cfg.Endpoint)
6969
s.client.SetHTTPClient(client)
7070
return nil
71-
})
71+
}),
7272
)
7373
}
7474

75-
func (scraper) scrape(ctx context.Context) (pmetric.Metrics, error) {
75+
func (s scraper) scrape(ctx context.Context) (pmetric.Metrics, error) {
7676
// To be filled in
7777
return pmetric.NewMetrics(), nil
7878
}
@@ -91,7 +91,7 @@ and measure of many projects have onboarded. To do this we will call the jenkins
9191
and if it reports an error, return that with no metrics, otherwise, emit the data from the metric builder.
9292

9393
```go
94-
func (s scrape) scrape(ctx context.Context) (pmetric.Metrics, error) {
94+
func (s scraper) scrape(ctx context.Context) (pmetric.Metrics, error) {
9595
jobs, err := s.client.GetJobs()
9696
if err != nil {
9797
return pmetric.Metrics{}, err
@@ -118,7 +118,7 @@ there was. Within this step, we are going to examine each job and use the report
118118
to capture metrics.
119119

120120
```go
121-
func (s scrape) scrape(ctx context.Context) (pmetric.Metrics, error) {
121+
func (s scraper) scrape(ctx context.Context) (pmetric.Metrics, error) {
122122
jobs, err := s.client.GetJobs()
123123
if err != nil {
124124
return pmetric.Metrics{}, err
@@ -171,7 +171,7 @@ The final step is to calculate how long it took from
171171
commit to job completion to help infer our DORA metrics.
172172

173173
```go
174-
func (s scrape) scrape(ctx context.Context) (pmetric.Metrics, error) {
174+
func (s scraper) scrape(ctx context.Context) (pmetric.Metrics, error) {
175175
jobs, err := s.client.GetJobs()
176176
if err != nil {
177177
return pmetric.Metrics{}, err

0 commit comments

Comments
 (0)