Sync AWS and Multipass terraform/cloud-init

Author: rcastley

multipass/main.tf

@@ -11,71 +11,74 @@ terraform {
 
 variable "splunk_access_token" {
   description = "Splunk Observability Cloud Access Token"
-  type = string
-  default = ""
+  type        = string
+  default     = ""
 }
 
 variable "splunk_rum_token" {
   description = "Splunk Observability Cloud RUM Token"
-  type = string
-  default = ""
+  type        = string
+  default     = ""
 }
 
 variable "splunk_realm" {
   description = "Splunk Observability Cloud Realm (us0, us1, us2, eu0, jp0, au0)"
-  type = string
-  default = ""
+  type        = string
+  default     = ""
 }
 
 variable "splunk_presetup" {
   description = "Pre configure the instance? (true/false)"
-  type = bool
-  default = false
+  type        = bool
+  default     = false
 }
 
 variable "splunk_jdk" {
   description = "Enabled Java Development environment? (true/false)"
-  type = bool
-  default = false
+  type        = bool
+  default     = false
 }
 
-data "template_file" "user_data" {
-  template = "${file("../workshop/aws/ec2/templates/userdata.yaml")}"
-  vars = {
-    access_token = "${var.splunk_access_token}"
-    rum_token = "${var.splunk_rum_token}"
-    realm = "${var.splunk_realm}"
-    presetup = "${var.splunk_presetup}"
-    jdk = "${var.splunk_jdk}"
+resource "random_string" "hostname" {
+  length  = 4
+  lower   = true
+  upper   = false
+  special = false
+  numeric = false
+}
+
+locals {
+  template_vars = {
+    access_token  = var.splunk_access_token
+    rum_token     = var.splunk_rum_token
+    realm         = var.splunk_realm
+    presetup      = var.splunk_presetup
+    jdk           = var.splunk_jdk
     instance_name = "${random_string.hostname.result}"
   }
 }
 
+data "template_file" "user_data" {
+  template = templatefile("../workshop/aws/ec2/templates/userdata.yaml", merge(local.template_vars))
+}
+
 resource "local_file" "user_data" {
   filename = "ubuntu-cloudinit.yml"
   content  = data.template_file.user_data.rendered
 }
 
-resource "random_string" "hostname" {
-  length = 4
-  lower  = true
-  upper  = false
-  special = false
-  numeric = false
-}
-
 resource "multipass_instance" "ubuntu" {
-  name = random_string.hostname.result
-  memory = "8GiB"
-  disk = "32GiB"
-  cpus = 4
-  image  = "jammy"
+  name           = random_string.hostname.result
+  memory         = "8GiB"
+  disk           = "32GiB"
+  cpus           = 4
+  image          = "jammy"
   cloudinit_file = local_file.user_data.filename
 
   lifecycle {
     precondition {
       # if splunk_presetup=true, tokens and realm cannot be empty
-      condition     = var.splunk_presetup ? try(var.splunk_access_token, "") != "" && try(var.splunk_realm, "") != "" && try(var.splunk_rum_token, "") != "": true
+      condition     = var.splunk_presetup ? try(var.splunk_access_token, "") != "" && try(var.splunk_realm, "") != "" && try(var.splunk_rum_token, "") != "" : true
       error_message = "When requesting a pre-setup instance, splunk_realm, splunk_access_token and splunk_rum_token are required and cannot be null/empty"
     }
   }

workshop/aws/ec2/config.tf

@@ -1,17 +1,17 @@
 provider "aws" {
-#  profile = "default"
-  region  = var.aws_region
+  #  profile = "default"
+  region = var.aws_region
 }
 
 locals {
   common_tags = {
-    Component = "o11y-for-${var.slug}"
+    Component   = "o11y-for-${var.slug}"
     Environment = "production"
   }
 }
 
 resource "aws_vpc" "o11y-ws-vpc" {
-  cidr_block = "10.13.0.0/16"
+  cidr_block           = "10.13.0.0/16"
   enable_dns_support   = true
   enable_dns_hostnames = true
   tags = merge(
@@ -36,8 +36,8 @@ resource "aws_subnet" "o11y-ws-subnet" {
 }
 
 resource "aws_security_group" "o11y-ws-sg" {
-  name = "Observability-Workshop-SG"
-  vpc_id      = aws_vpc.o11y-ws-vpc.id
+  name   = "Observability-Workshop-SG"
+  vpc_id = aws_vpc.o11y-ws-vpc.id
 
   ingress {
     from_port   = 22
@@ -143,10 +143,10 @@ resource "aws_route_table_association" "o11y-ws-rta" {
 locals {
   template_vars = {
     access_token = var.splunk_access_token
-    rum_token = var.splunk_rum_token
-    realm = var.splunk_realm
-    presetup = var.splunk_presetup
-    jdk = var.splunk_jdk
+    rum_token    = var.splunk_rum_token
+    realm        = var.splunk_realm
+    presetup     = var.splunk_presetup
+    jdk          = var.splunk_jdk
   }
 }
 
@@ -156,10 +156,10 @@ resource "aws_instance" "observability-instance" {
   instance_type          = var.aws_instance_type
   subnet_id              = aws_subnet.o11y-ws-subnet.id
   vpc_security_group_ids = [aws_security_group.o11y-ws-sg.id]
-  user_data              = templatefile("${path.module}/templates/userdata.yaml", merge(local.template_vars,
+  user_data = templatefile("${path.module}/templates/userdata.yaml", merge(local.template_vars,
     {
       instance_name = "${var.slug}-${count.index + 1}"
-    }))
+  }))
 
   root_block_device {
     volume_size = var.instance_disk_aws
@@ -177,7 +177,7 @@ resource "aws_instance" "observability-instance" {
   lifecycle {
     precondition {
       # if splunk_presetup=true, tokens and realm cannot be empty
-      condition     = var.splunk_presetup ? try(var.splunk_access_token, "") != "" && try(var.splunk_realm, "") != "" && try(var.splunk_rum_token, "") != "": true
+      condition     = var.splunk_presetup ? try(var.splunk_access_token, "") != "" && try(var.splunk_realm, "") != "" && try(var.splunk_rum_token, "") != "" : true
       error_message = "When requesting a pre-setup instance, splunk_realm, splunk_access_token and splunk_rum_token are required and cannot be null/empty"
     }
   }