Moved output to outputs.tf

Author: rcastley

workshop/aws/ec2/main.tf

@@ -1,5 +1,4 @@
 provider "aws" {
-  #  profile = "default"
   region = var.aws_region
 }
 
@@ -26,7 +25,6 @@ resource "aws_vpc" "o11y-ws-vpc" {
   )
 }
 
-
 # Create public subnets, each in a different AZ
 resource "aws_subnet" "o11y_ws_subnets" {
   count                   = var.subnet_count
@@ -223,22 +221,3 @@ resource "aws_instance" "observability-instance" {
     }
   }
 }
-
-#output "instance_details" {
-#  value = formatlist(
-#    "%s, %s, %s, %s",
-#    aws_instance.observability-instance[*].tags["Instance"],
-#    aws_instance.observability-instance.*.private_ip,
-#    aws_instance.observability-instance.*.public_ip,
-#    aws_instance.observability-instance[*].tags["Subnet"]
-#  )
-#}
-
-output "login_details" {
-  value = formatlist(
-    "%s, %s, %s",
-    aws_instance.observability-instance[*].tags["Instance"],
-    aws_instance.observability-instance.*.public_ip,
-    local.template_vars.instance_password
-  )
-}

workshop/aws/ec2/outputs.tf

@@ -13,3 +13,12 @@ output "instance_names" {
 output "instance_password" {
   value = random_string.password.result
 }
+
+output "login_details" {
+  value = formatlist(
+    "%s, %s, %s",
+    aws_instance.observability-instance[*].tags["Instance"],
+    aws_instance.observability-instance.*.public_ip,
+    local.template_vars.instance_password
+  )
+}