From d7f30e7f37bbb82fe806ab6861c940d31236b358 Mon Sep 17 00:00:00 2001 From: Anna Urbiztondo Date: Tue, 12 Nov 2024 08:03:08 +0100 Subject: [PATCH 1/2] Clarifications --- gdi/get-data-in/rum/browser/browser-rum-api-reference.rst | 8 ++++++++ rum/rum-custom-indexed-tags.rst | 4 +--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/gdi/get-data-in/rum/browser/browser-rum-api-reference.rst b/gdi/get-data-in/rum/browser/browser-rum-api-reference.rst index 8f4acef34..2dec39179 100644 --- a/gdi/get-data-in/rum/browser/browser-rum-api-reference.rst +++ b/gdi/get-data-in/rum/browser/browser-rum-api-reference.rst @@ -12,6 +12,8 @@ Use the following API methods when creating manual instrumentation for Splunk RU .. note:: ``try ... catch`` blocks can prevent your app from crashing when using the CDN version of Browser RUM. +.. _browser-rum-methods: + Methods ========================= @@ -130,3 +132,9 @@ The following example shows how to add an event listener to track changes of ses SplunkRum.addEventListener('session-changed', (event) => { LiveChat.setMetadata('splunk.sessionId', event.payload.sessionId); }); + +Migrate to OpenTelemetry +============================== + +If you have some existing manual instrumentation of your app you can translate the code to use OpenTelemetry conventions. See how in GitHub's :new-page:`Migrating Manual Instrumentation https://github.com/signalfx/splunk-otel-js-web/blob/13cb35597773c251d7ec0df08cecabf5fbc4bcb2/docs/MigratingInstrumentation.md#custom-properties--tags--attributes>`. + diff --git a/rum/rum-custom-indexed-tags.rst b/rum/rum-custom-indexed-tags.rst index 34c7c2123..36d65b376 100644 --- a/rum/rum-custom-indexed-tags.rst +++ b/rum/rum-custom-indexed-tags.rst @@ -33,14 +33,12 @@ Here are some examples of what you could use as span tags: .. "How can I add my own tags to Tag Spotlight?", "How can I filter on custom tags?" "How can I troubleshoot with custom tags? - - Add custom tags to Tag Spotlight ======================================================== You need to be an admin to do this task. Follow these steps to add custom tags to Tag Spotlight: -1. Add a span tag following these steps: :ref:`create-a-span-rum`. +1. Add a span tag following as explained in :ref:`create-a-span-rum`. To add attributes to the span, see RUM's API :ref:`browser-rum-methods`. 2. There are two ways to navigate to the MetricSets configuration page. Choose either one: From 2c3b572919b5314ba148bf497a285bb6be2a0cbc Mon Sep 17 00:00:00 2001 From: Anna Urbiztondo Date: Tue, 12 Nov 2024 08:46:00 +0100 Subject: [PATCH 2/2] Fixes --- gdi/get-data-in/rum/browser/browser-rum-api-reference.rst | 2 +- rum/rum-custom-indexed-tags.rst | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gdi/get-data-in/rum/browser/browser-rum-api-reference.rst b/gdi/get-data-in/rum/browser/browser-rum-api-reference.rst index 2dec39179..d43032cef 100644 --- a/gdi/get-data-in/rum/browser/browser-rum-api-reference.rst +++ b/gdi/get-data-in/rum/browser/browser-rum-api-reference.rst @@ -136,5 +136,5 @@ The following example shows how to add an event listener to track changes of ses Migrate to OpenTelemetry ============================== -If you have some existing manual instrumentation of your app you can translate the code to use OpenTelemetry conventions. See how in GitHub's :new-page:`Migrating Manual Instrumentation https://github.com/signalfx/splunk-otel-js-web/blob/13cb35597773c251d7ec0df08cecabf5fbc4bcb2/docs/MigratingInstrumentation.md#custom-properties--tags--attributes>`. +If you have some existing manual instrumentation of your app you can translate the code to use OpenTelemetry conventions. See how in GitHub's :new-page:`Migrating Manual Instrumentation `. diff --git a/rum/rum-custom-indexed-tags.rst b/rum/rum-custom-indexed-tags.rst index 36d65b376..a0507130f 100644 --- a/rum/rum-custom-indexed-tags.rst +++ b/rum/rum-custom-indexed-tags.rst @@ -38,7 +38,7 @@ Add custom tags to Tag Spotlight You need to be an admin to do this task. Follow these steps to add custom tags to Tag Spotlight: -1. Add a span tag following as explained in :ref:`create-a-span-rum`. To add attributes to the span, see RUM's API :ref:`browser-rum-methods`. +1. Add a span tag as explained in :ref:`create-a-span-rum`. To add attributes to the span, see RUM's API :ref:`browser-rum-methods`. 2. There are two ways to navigate to the MetricSets configuration page. Choose either one: